Subject: Re: [PATCH 1/4] powerpc/fsl-booke: Add device tree support for T1024/T1023 SoC

From: Scott Wood <[email-masked]>
Date: Tue, 7 Apr 2015 18:49:09 -0500

On Fri, 2015-04-03 at 18:35 +0800, Shengzhou Liu wrote:
> +	rcpm: global-utilities@e2000 {
> +		compatible = "fsl,t1023-rcpm", "fsl,qoriq-rcpm-2.0";
> +		reg = <0xe2000 0x1000>;
> +	};
> +
> +	sfp: sfp@e8000 {
> +		compatible = "fsl,t1023-sfp";
> +		reg	   = <0xe8000 0x1000>;
> +	};
> +
> +	serdes: serdes@ea000 {
> +		compatible = "fsl,t1023-serdes";
> +		reg	   = <0xea000 0x4000>;
> +	};

Consistent whitespace please.  Just one space after "reg".

> +/include/ "qoriq-esdhc-0.dtsi"
> +	sdhc@114000 {
> +		compatible = "fsl,t1023-esdhc", "fsl,esdhc";
> +		fsl,iommu-parent = <&pamu0>;
> +		fsl,liodn-reg = <&guts 0x530>; /* eSDHCLIODNR */
> +		sdhci,auto-cmd12;
> +		no-1-8-v;
> +		sleep = <&rcpm 0x00000080>;

Get rid of "sleep" -- it's undocumented copy-and-paste from something
that was never finished.

-Scott