Subject: Re: [PATCH] QorIQ/TMU: add TMU node to device tree for QorIQ T104x

From: Scott Wood <[email-masked]>
Date: Thu, 9 Apr 2015 22:55:40 -0500

On Tue, 2015-03-31 at 14:17 +0800, Jia Hongtao wrote:
> This is Thermal Monitoring Unit for QorIQ platform.
> 
> Signed-off-by: Jia Hongtao <[email-masked]>
> ---
>  .../devicetree/bindings/thermal/qoriq-thermal.txt  | 58 +++++++++++++++
>  arch/powerpc/boot/dts/fsl/qoriq-tmu-t104xsi.dtsi   | 82 ++++++++++++++++++++++
>  arch/powerpc/boot/dts/fsl/t1040si-post.dtsi        |  1 +
>  3 files changed, 141 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
>  create mode 100644 arch/powerpc/boot/dts/fsl/qoriq-tmu-t104xsi.dtsi
> 
> diff --git a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> new file mode 100644
> index 0000000..dfc17fa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> @@ -0,0 +1,58 @@
> +* Thermal Monitoring Unit (TMU) on Freescale QorIQ SoCs
> +
> +Required properties:
> +- compatible : "fsl,qoriq-tmu".

compatible: Must include "fsl,qoriq-tmu". The version of the device is
	    determined by the TMU IP Block Revision Register (IPBRR0)
	    at offset 0x0BF8.

	    Table of correspondences between IPBRR0 values and example  
	    chips:
		Value           Device
		-----------     -------
		0x01900102      T1040

> +- reg : address range of TMU registers.
> +- interrupts : should contain the interrupt for TMU.

s/should contain/contains/

> +- calibration : calibration table for TMU.

What is the format of the calibration table, and where does one get the
data?

-Scott