From: Michael Ellerman <mpe@ellerman•id.au>
To: Li Zhong <zhong@linux•vnet.ibm.com>
Cc: Paul Mackerras <paulus@samba•org>,
Sukadev Bhattiprolu <sukadev@linux•vnet.ibm.com>,
PowerPC email list <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [RFC v2 powerpc] perf/hv-24x7 fail 24x7 initcall if create_events_from_catalog() fails
Date: Fri, 10 Apr 2015 20:55:58 +1000 [thread overview]
Message-ID: <1428663358.21137.4.camel@ellerman.id.au> (raw)
In-Reply-To: <1428655351.16563.11.camel@TP420>
On Fri, 2015-04-10 at 16:42 +0800, Li Zhong wrote:
> As Michael pointed out, create_events_from_catalog() fails when
> we either have:
> - a kernel bug
> - some sort of hypervisor misconfiguration
> - ENOMEM
>
> In all the above cases, we can also fail 24x7 initcall.
Thanks.
> In the patch below, I used ENODEV for hypervisor errors, not sure
> whether some other error values is more proper here.
ENODEV is a special case, if an initcall returns ENODEV no error is reported to
dmesg.
In this case I think we would like an error to be reported, so EIO would be
better I think.
cheers
next prev parent reply other threads:[~2015-04-10 10:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-15 9:42 [RFC PATCH powerpc] perf/hv-24x7 set the attr group to NULL if events failed to be initialized Li Zhong
2015-03-25 9:51 ` [RFC, " Michael Ellerman
2015-03-25 18:41 ` Sukadev Bhattiprolu
2015-03-26 3:51 ` Michael Ellerman
2015-04-10 8:42 ` [RFC v2 powerpc] perf/hv-24x7 fail 24x7 initcall if create_events_from_catalog() fails Li Zhong
2015-04-10 10:55 ` Michael Ellerman [this message]
2015-04-13 7:48 ` [PATCH v3 " Li Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428663358.21137.4.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
--cc=sukadev@linux$(echo .)vnet.ibm.com \
--cc=zhong@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox