Subject: Re: [v2] dt/bindings: fsl/guts: Added global-utilities compatibles

From: Scott Wood <[email-masked]>
Date: Wed, 15 Apr 2015 12:16:20 -0500

On Wed, 2015-04-15 at 03:43 -0500, Liberman Igal-B31950 wrote:
> 
> 
> Regards,
> Igal Liberman.
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Tuesday, April 14, 2015 11:09 PM
> > To: Liberman Igal-B31950
> > Cc: [email-masked]; [email-masked]
> > Subject: Re: [v2] dt/bindings: fsl/guts: Added global-utilities compatibles
> > 
> > On Tue, 2015-04-14 at 13:12 +0300, Igal.Liberman wrote:
> > > From: Igal Liberman <[email-masked]>
> > >
> > > v2 - Addressed Scott's feedback
> > >
> > > Signed-off-by: Igal Liberman <[email-masked]>
> > > ---
> > >  .../devicetree/bindings/powerpc/fsl/guts.txt       |    4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
> > b/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
> > > index 7f150b5..69644e6 100644
> > > --- a/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
> > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/guts.txt
> > > @@ -9,6 +9,10 @@ Required properties:
> > >
> > >   - compatible : Should define the compatible device type for
> > >     global-utilities.
> > > +   Possible compatibles:
> > > +	"fsl,qoriq-device-config-1.0"
> > > +	"fsl,qoriq-device-config-2.0"
> > > +	"fsl,<chip>-device-config"
> > 
> > fsl,<chip>-guts is also possible on non-corenet chips.
> > 
> 
> I added compatibles which are used for FMan Clock only.
> Do you want to add other compatibles too? Which? Or just mention that the 3 compatibles I've added doesn't cover all available options?

You're changing the binding from one that doesn't list compatibles to
one that does -- so please get all of them.

-Scott