Subject: Re: [PATCH 2/2] powerpc: Disable building the 32-bit VDSO on little endian

From: Scott Wood <[email-masked]>
Date: Tue, 21 Apr 2015 13:36:49 -0500

On Tue, 2015-04-21 at 19:41 +1000, Michael Ellerman wrote:
> diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype
> index 12fc443b9d54..1324f589f43a 100644
> --- a/arch/powerpc/platforms/Kconfig.cputype
> +++ b/arch/powerpc/platforms/Kconfig.cputype
> @@ -405,6 +405,16 @@ config PPC_DOORBELL
>  
>  endmenu
>  
> +config VDSO32
> +	def_bool y
> +	depends on PPC32 || CPU_BIG_ENDIAN
> +	help
> +	  This symbol controls whether we build the 32-bit VDSO. We obviously
> +	  want to do that if we're building a 32-bit kernel. If we're building
> +	  a 64-bit kernel then we only want a 32-bit VDSO if we're building for
> +	  big endian. That is because the only little endian configuration we
> +	  support is ppc64le which is 64-bit only.

Shouldn't this depend on COMPAT, and COMPAT depend on CPU_BIG_ENDIAN?

-Scott