public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman•id.au>
To: Scott Wood <scottwood@freescale•com>
Cc: linuxppc-dev@ozlabs•org, sam.mj@au1•ibm.com,
	Anton Blanchard <anton@samba•org>
Subject: Re: [PATCH 1/2] powerpc: Little endian should depend on PPC64
Date: Wed, 22 Apr 2015 10:27:12 +1000	[thread overview]
Message-ID: <1429662432.15241.1.camel@ellerman.id.au> (raw)
In-Reply-To: <1429641183.4352.108.camel@freescale.com>

On Tue, 2015-04-21 at 13:33 -0500, Scott Wood wrote:
> On Tue, 2015-04-21 at 19:41 +1000, Michael Ellerman wrote:
> > The only little endian configuration we support is ppc64le, so we
> > shouldn't be asking which endian to use when building 32-bit kernels,
> > they are always big endian.
> > 
> > Signed-off-by: Michael Ellerman <mpe@ellerman•id.au>
> > ---
> >  arch/powerpc/platforms/Kconfig.cputype | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype
> > index 7264e91190be..12fc443b9d54 100644
> > --- a/arch/powerpc/platforms/Kconfig.cputype
> > +++ b/arch/powerpc/platforms/Kconfig.cputype
> > @@ -421,6 +421,7 @@ config CPU_BIG_ENDIAN
> >  
> >  config CPU_LITTLE_ENDIAN
> >  	bool "Build little endian kernel"
> > +	depends on PPC64
> >  	select PPC64_BOOT_WRAPPER
> >  	help
> >  	  Build a little endian kernel.
> 
> Shouldn't this be PPC_BOOK3S_64?

Ah yeah, stupid BOOKE :)

Currently it's nothing so PPC64 was an improvement, but you're right, if we're
building 64-bit BOOKE then we shouldn't prompt.

cheers

      reply	other threads:[~2015-04-22  0:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-21  9:41 [PATCH 1/2] powerpc: Little endian should depend on PPC64 Michael Ellerman
2015-04-21  9:41 ` [PATCH 2/2] powerpc: Disable building the 32-bit VDSO on little endian Michael Ellerman
2015-04-21 18:36   ` Scott Wood
2015-04-22  0:30     ` Michael Ellerman
2015-04-21 22:23   ` Stephen Rothwell
2015-04-21 18:33 ` [PATCH 1/2] powerpc: Little endian should depend on PPC64 Scott Wood
2015-04-22  0:27   ` Michael Ellerman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429662432.15241.1.camel@ellerman.id.au \
    --to=mpe@ellerman$(echo .)id.au \
    --cc=anton@samba$(echo .)org \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=sam.mj@au1$(echo .)ibm.com \
    --cc=scottwood@freescale$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox