From: Michael Ellerman <mpe@ellerman•id.au>
To: Tyrel Datwyler <tyreld@linux•vnet.ibm.com>
Cc: Nathan Fontenot <nfont@linux•vnet.ibm.com>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH] powerpc/pseries: Fix possible leaked device node reference
Date: Fri, 01 May 2015 09:47:22 +1000 [thread overview]
Message-ID: <1430437642.32679.1.camel@ellerman.id.au> (raw)
In-Reply-To: <5542A589.9010703@linux.vnet.ibm.com>
On Thu, 2015-04-30 at 14:58 -0700, Tyrel Datwyler wrote:
> On 04/29/2015 06:44 PM, Nathan Fontenot wrote:
> > Failure return from dlpar_configure_connector when dlpar adding cpus
> > results in leaking references to the cpus parent device node. Move the
> > call to of_node_put() prior to checking the result of
> > dlpar_configure_connector.
> >
> > Fixes: 8d5ff320766f ("powerpc/pseries: Make dlpar_configure_connector parent node aware")
>
> That commit went into 3.12. Shouldn't this be CC to stable?
It could, but it fails the "real bug" test:
- It must fix a real bug that bothers people (not a, "This could be a
problem..." type thing).
(from Documentation/stable_kernel_rules.txt)
Because the node we're leaking a reference on is /cpus, and in practice that's
pretty harmless.
cheers
prev parent reply other threads:[~2015-04-30 23:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 1:44 [PATCH] powerpc/pseries: Fix possible leaked device node reference Nathan Fontenot
2015-04-30 21:58 ` Tyrel Datwyler
2015-04-30 23:47 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430437642.32679.1.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=nfont@linux$(echo .)vnet.ibm.com \
--cc=tyreld@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox