Subject: Re: Document and implement an improved flash device binding

From: Segher Boessenkool <[email-masked]>
Date: Mon, 3 Sep 2007 12:23:34 +0200

> +   j) CFI or JEDEC memory-mapped NOR flash
>
>      Flash chips (Memory Technology Devices) are often used for solid 
> state
>      file systems on embedded devices.

Well, almost everything has a NOR flash on it, not just
embedded boards ;-)

> +     - bank-width : Width (in bytes) of the flash bank.  Equal to the
> +       device width times the number of interleaved chips.
> +     - device-width : (optional) Width of a single flash chip.  If
> +       omitted, assumed to be equal to 'bank-width'.

Let's have bank-width optional instead, it's more natural
that way for the common case of just one chip.  Or, you can
say that either is optional.

> +	flash@ff000000 {
> +		compatible = "amd,am29lv128ml", "cfi-flash";
> +		reg = <ff000000 01000000>;
> +		bank-width = <4>;

This is an 8/16-bit part, you need a device-width ;-)

Need #address-cells here for the child nodes:

> +		fs@0 {
> +			reg = <0 f80000>;
> +		};

[big snip]

> +					OpenBIOS@0 {

This show immediately why node name = partition name won't
work out.  You're not supposed to start a node name with a
capital like this.

Segher