* [PATCH] powerpc/dts: Add 1588 timer node for eTSEC
@ 2015-05-06 9:40 Yangbo Lu
2015-05-06 20:44 ` Scott Wood
0 siblings, 1 reply; 5+ messages in thread
From: Yangbo Lu @ 2015-05-06 9:40 UTC (permalink / raw)
To: linuxppc-dev, linux-kernel, scottwood; +Cc: Yangbo Lu
Add 1588 timer node in files:
arch/powerpc/boot/dts/bsc9131rdb.dtsi
arch/powerpc/boot/dts/bsc9132qds.dtsi
arch/powerpc/boot/dts/p1010rdb.dtsi
arch/powerpc/boot/dts/p1020rdb-pd.dts
arch/powerpc/boot/dts/p1021rdb-pc.dtsi
arch/powerpc/boot/dts/p1022ds.dtsi
arch/powerpc/boot/dts/p1025twr.dtsi
arch/powerpc/boot/dts/p2020rdb-pc.dtsi
Signed-off-by: Yangbo Lu <yangbo.lu@freescale•com>
---
arch/powerpc/boot/dts/bsc9131rdb.dtsi | 12 ++++++++++++
arch/powerpc/boot/dts/bsc9132qds.dtsi | 12 ++++++++++++
arch/powerpc/boot/dts/p1010rdb.dtsi | 12 ++++++++++++
arch/powerpc/boot/dts/p1020rdb-pd.dts | 12 ++++++++++++
arch/powerpc/boot/dts/p1021rdb-pc.dtsi | 12 ++++++++++++
arch/powerpc/boot/dts/p1022ds.dtsi | 12 ++++++++++++
arch/powerpc/boot/dts/p1025twr.dtsi | 12 ++++++++++++
arch/powerpc/boot/dts/p2020rdb-pc.dtsi | 15 +++++++++------
8 files changed, 93 insertions(+), 6 deletions(-)
diff --git a/arch/powerpc/boot/dts/bsc9131rdb.dtsi b/arch/powerpc/boot/dts/bsc9131rdb.dtsi
index 45efcba..629cc03 100644
--- a/arch/powerpc/boot/dts/bsc9131rdb.dtsi
+++ b/arch/powerpc/boot/dts/bsc9131rdb.dtsi
@@ -80,6 +80,18 @@
status = "disabled";
};
+ ptp_clock@b0e00 {
+ compatible = "fsl,etsec-ptp";
+ reg = <0xb0e00 0xb0>;
+ interrupts = <68 2 0 0 69 2 0 0>;
+ fsl,tclk-period = <5>;
+ fsl,tmr-prsc = <2>;
+ fsl,tmr-add = <0xcccccccd>;
+ fsl,tmr-fiper1 = <0x3b9ac9fb>;
+ fsl,tmr-fiper2 = <0x00018696>;
+ fsl,max-adj = <249999999>;
+ };
+
enet0: ethernet@b0000 {
phy-handle = <&phy0>;
phy-connection-type = "rgmii-id";
diff --git a/arch/powerpc/boot/dts/bsc9132qds.dtsi b/arch/powerpc/boot/dts/bsc9132qds.dtsi
index af8e888..9d8d466 100644
--- a/arch/powerpc/boot/dts/bsc9132qds.dtsi
+++ b/arch/powerpc/boot/dts/bsc9132qds.dtsi
@@ -87,6 +87,18 @@
};
};
+ ptp_clock@b0e00 {
+ compatible = "fsl,etsec-ptp";
+ reg = <0xb0e00 0xb0>;
+ interrupts = <68 2 0 0 69 2 0 0>;
+ fsl,tclk-period = <5>;
+ fsl,tmr-prsc = <2>;
+ fsl,tmr-add = <0xcccccccd>;
+ fsl,tmr-fiper1 = <0x3b9ac9fb>;
+ fsl,tmr-fiper2 = <0x00018696>;
+ fsl,max-adj = <249999999>;
+ };
+
enet0: ethernet@b0000 {
phy-handle = <&phy0>;
tbi-handle = <&tbi0>;
diff --git a/arch/powerpc/boot/dts/p1010rdb.dtsi b/arch/powerpc/boot/dts/p1010rdb.dtsi
index ea534ef..a454cfe 100644
--- a/arch/powerpc/boot/dts/p1010rdb.dtsi
+++ b/arch/powerpc/boot/dts/p1010rdb.dtsi
@@ -186,6 +186,18 @@
};
};
+ ptp_clock@b0e00 {
+ compatible = "fsl,etsec-ptp";
+ reg = <0xb0e00 0xb0>;
+ interrupts = <68 2 0 0 69 2 0 0>;
+ fsl,tclk-period = <10>;
+ fsl,tmr-prsc = <2>;
+ fsl,tmr-add = <0x80000016>;
+ fsl,tmr-fiper1 = <0x3b9ac9f6>;
+ fsl,tmr-fiper2 = <0x00018696>;
+ fsl,max-adj = <199999999>;
+ };
+
enet0: ethernet@b0000 {
phy-handle = <&phy0>;
phy-connection-type = "rgmii-id";
diff --git a/arch/powerpc/boot/dts/p1020rdb-pd.dts b/arch/powerpc/boot/dts/p1020rdb-pd.dts
index 987017e..2d45195 100644
--- a/arch/powerpc/boot/dts/p1020rdb-pd.dts
+++ b/arch/powerpc/boot/dts/p1020rdb-pd.dts
@@ -225,6 +225,18 @@
};
};
+ ptp_clock@b0e00 {
+ compatible = "fsl,etsec-ptp";
+ reg = <0xb0e00 0xb0>;
+ interrupts = <68 2 0 0 69 2 0 0>;
+ fsl,tclk-period = <10>;
+ fsl,tmr-prsc = <2>;
+ fsl,tmr-add = <0x80000016>;
+ fsl,tmr-fiper1 = <0x3b9ac9f6>;
+ fsl,tmr-fiper2 = <0x00018696>;
+ fsl,max-adj = <199999999>;
+ };
+
enet0: ethernet@b0000 {
fixed-link = <1 1 1000 0 0>;
phy-connection-type = "rgmii-id";
diff --git a/arch/powerpc/boot/dts/p1021rdb-pc.dtsi b/arch/powerpc/boot/dts/p1021rdb-pc.dtsi
index d6274c5..3a2c12c 100644
--- a/arch/powerpc/boot/dts/p1021rdb-pc.dtsi
+++ b/arch/powerpc/boot/dts/p1021rdb-pc.dtsi
@@ -224,6 +224,18 @@
};
};
+ ptp_clock@b0e00 {
+ compatible = "fsl,etsec-ptp";
+ reg = <0xb0e00 0xb0>;
+ interrupts = <68 2 0 0 69 2 0 0>;
+ fsl,tclk-period = <10>;
+ fsl,tmr-prsc = <2>;
+ fsl,tmr-add = <0x80000016>;
+ fsl,tmr-fiper1 = <0x3b9ac9f6>;
+ fsl,tmr-fiper2 = <0x00018696>;
+ fsl,max-adj = <199999999>;
+ };
+
enet0: ethernet@b0000 {
fixed-link = <1 1 1000 0 0>;
phy-connection-type = "rgmii-id";
diff --git a/arch/powerpc/boot/dts/p1022ds.dtsi b/arch/powerpc/boot/dts/p1022ds.dtsi
index 957e0dc..75cdac2 100644
--- a/arch/powerpc/boot/dts/p1022ds.dtsi
+++ b/arch/powerpc/boot/dts/p1022ds.dtsi
@@ -215,6 +215,18 @@
};
};
+ ptp_clock@b0e00 {
+ compatible = "fsl,etsec-ptp";
+ reg = <0xb0e00 0xb0>;
+ interrupts = <68 2 0 0 69 2 0 0>;
+ fsl,tclk-period = <5>;
+ fsl,tmr-prsc = <2>;
+ fsl,tmr-add = <0xc01ebd3d>;
+ fsl,tmr-fiper1 = <0x3b9ac9fb>;
+ fsl,tmr-fiper2 = <0x00018696>;
+ fsl,max-adj = <266499999>;
+ };
+
ethernet@b0000 {
phy-handle = <&phy0>;
phy-connection-type = "rgmii-id";
diff --git a/arch/powerpc/boot/dts/p1025twr.dtsi b/arch/powerpc/boot/dts/p1025twr.dtsi
index 8453501..860b133 100644
--- a/arch/powerpc/boot/dts/p1025twr.dtsi
+++ b/arch/powerpc/boot/dts/p1025twr.dtsi
@@ -138,6 +138,18 @@
};
};
+ ptp_clock@b0e00 {
+ compatible = "fsl,etsec-ptp";
+ reg = <0xb0e00 0xb0>;
+ interrupts = <68 2 0 0 69 2 0 0>;
+ fsl,tclk-period = <10>;
+ fsl,tmr-prsc = <2>;
+ fsl,tmr-add = <0xc0000021>;
+ fsl,tmr-fiper1 = <0x3b9ac9f6>;
+ fsl,tmr-fiper2 = <0x00018696>;
+ fsl,max-adj = <133333332>;
+ };
+
enet0: ethernet@b0000 {
phy-handle = <&phy0>;
phy-connection-type = "rgmii-id";
diff --git a/arch/powerpc/boot/dts/p2020rdb-pc.dtsi b/arch/powerpc/boot/dts/p2020rdb-pc.dtsi
index c21d1c7..434e21b 100644
--- a/arch/powerpc/boot/dts/p2020rdb-pc.dtsi
+++ b/arch/powerpc/boot/dts/p2020rdb-pc.dtsi
@@ -215,12 +215,15 @@
};
ptp_clock@24e00 {
- fsl,tclk-period = <5>;
- fsl,tmr-prsc = <200>;
- fsl,tmr-add = <0xCCCCCCCD>;
- fsl,tmr-fiper1 = <0x3B9AC9FB>;
- fsl,tmr-fiper2 = <0x0001869B>;
- fsl,max-adj = <249999999>;
+ compatible = "fsl,etsec-ptp";
+ reg = <0x24e00 0xb0>;
+ interrupts = <68 2 0 0 69 2 0 0>;
+ fsl,tclk-period = <5>;
+ fsl,tmr-prsc = <2>;
+ fsl,tmr-add = <0xaaaaaaab>;
+ fsl,tmr-fiper1 = <0x3b9ac9fb>;
+ fsl,tmr-fiper2 = <0x00018696>;
+ fsl,max-adj = <299999999>;
};
enet0: ethernet@24000 {
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/dts: Add 1588 timer node for eTSEC
2015-05-06 9:40 [PATCH] powerpc/dts: Add 1588 timer node for eTSEC Yangbo Lu
@ 2015-05-06 20:44 ` Scott Wood
2015-05-07 2:26 ` yangbo.lu
0 siblings, 1 reply; 5+ messages in thread
From: Scott Wood @ 2015-05-06 20:44 UTC (permalink / raw)
To: Yangbo Lu; +Cc: linuxppc-dev, linux-kernel
On Wed, 2015-05-06 at 17:40 +0800, Yangbo Lu wrote:
> Add 1588 timer node in files:
> arch/powerpc/boot/dts/bsc9131rdb.dtsi
> arch/powerpc/boot/dts/bsc9132qds.dtsi
> arch/powerpc/boot/dts/p1010rdb.dtsi
> arch/powerpc/boot/dts/p1020rdb-pd.dts
> arch/powerpc/boot/dts/p1021rdb-pc.dtsi
> arch/powerpc/boot/dts/p1022ds.dtsi
> arch/powerpc/boot/dts/p1025twr.dtsi
> arch/powerpc/boot/dts/p2020rdb-pc.dtsi
>
> Signed-off-by: Yangbo Lu <yangbo.lu@freescale•com>
> ---
> arch/powerpc/boot/dts/bsc9131rdb.dtsi | 12 ++++++++++++
> arch/powerpc/boot/dts/bsc9132qds.dtsi | 12 ++++++++++++
> arch/powerpc/boot/dts/p1010rdb.dtsi | 12 ++++++++++++
> arch/powerpc/boot/dts/p1020rdb-pd.dts | 12 ++++++++++++
> arch/powerpc/boot/dts/p1021rdb-pc.dtsi | 12 ++++++++++++
> arch/powerpc/boot/dts/p1022ds.dtsi | 12 ++++++++++++
> arch/powerpc/boot/dts/p1025twr.dtsi | 12 ++++++++++++
> arch/powerpc/boot/dts/p2020rdb-pc.dtsi | 15 +++++++++------
> 8 files changed, 93 insertions(+), 6 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/bsc9131rdb.dtsi b/arch/powerpc/boot/dts/bsc9131rdb.dtsi
> index 45efcba..629cc03 100644
> --- a/arch/powerpc/boot/dts/bsc9131rdb.dtsi
> +++ b/arch/powerpc/boot/dts/bsc9131rdb.dtsi
> @@ -80,6 +80,18 @@
> status = "disabled";
> };
>
> + ptp_clock@b0e00 {
> + compatible = "fsl,etsec-ptp";
> + reg = <0xb0e00 0xb0>;
> + interrupts = <68 2 0 0 69 2 0 0>;
> + fsl,tclk-period = <5>;
> + fsl,tmr-prsc = <2>;
> + fsl,tmr-add = <0xcccccccd>;
> + fsl,tmr-fiper1 = <0x3b9ac9fb>;
> + fsl,tmr-fiper2 = <0x00018696>;
> + fsl,max-adj = <249999999>;
Please don't use hex for numbers that make more sense as decimal.
> --- a/arch/powerpc/boot/dts/p2020rdb-pc.dtsi
> +++ b/arch/powerpc/boot/dts/p2020rdb-pc.dtsi
> @@ -215,12 +215,15 @@
> };
>
> ptp_clock@24e00 {
> - fsl,tclk-period = <5>;
> - fsl,tmr-prsc = <200>;
> - fsl,tmr-add = <0xCCCCCCCD>;
> - fsl,tmr-fiper1 = <0x3B9AC9FB>;
> - fsl,tmr-fiper2 = <0x0001869B>;
> - fsl,max-adj = <249999999>;
> + compatible = "fsl,etsec-ptp";
> + reg = <0x24e00 0xb0>;
> + interrupts = <68 2 0 0 69 2 0 0>;
> + fsl,tclk-period = <5>;
> + fsl,tmr-prsc = <2>;
> + fsl,tmr-add = <0xaaaaaaab>;
> + fsl,tmr-fiper1 = <0x3b9ac9fb>;
> + fsl,tmr-fiper2 = <0x00018696>;
> + fsl,max-adj = <299999999>;
> };
This isn't adding a node -- it's changing values. If the old ones were
wrong, explain that in the changelog.
Also, p2020si-post.dtsi already adds interrupts to this node (and it
contains one more interrupt than the above), and it includes
pq3-etsec1-timer-0.dtsi which contains the compatible and reg (and
interrupts with two specifiers). Probably all of these should be using
pq3-etsec1-timer-0.dtsi and only specifying the board-specific values.
-Scott
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] powerpc/dts: Add 1588 timer node for eTSEC
2015-05-06 20:44 ` Scott Wood
@ 2015-05-07 2:26 ` yangbo.lu
2015-05-07 2:34 ` Scott Wood
0 siblings, 1 reply; 5+ messages in thread
From: yangbo.lu @ 2015-05-07 2:26 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
VGhhbmtzLg0KUGxzIHNlZSBteSBjb21tZW50cyBiZWxvdy4NCg0KLS0tLS1PcmlnaW5hbCBNZXNz
YWdlLS0tLS0NCkZyb206IFdvb2QgU2NvdHQtQjA3NDIxIA0KU2VudDogVGh1cnNkYXksIE1heSAw
NywgMjAxNSA0OjQ0IEFNDQpUbzogTHUgWWFuZ2JvLUI0NzA5Mw0KQ2M6IGxpbnV4cHBjLWRldkBs
aXN0cy5vemxhYnMub3JnOyBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnDQpTdWJqZWN0OiBS
ZTogW1BBVENIXSBwb3dlcnBjL2R0czogQWRkIDE1ODggdGltZXIgbm9kZSBmb3IgZVRTRUMNCg0K
T24gV2VkLCAyMDE1LTA1LTA2IGF0IDE3OjQwICswODAwLCBZYW5nYm8gTHUgd3JvdGU6DQo+IEFk
ZCAxNTg4IHRpbWVyIG5vZGUgaW4gZmlsZXM6DQo+IGFyY2gvcG93ZXJwYy9ib290L2R0cy9ic2M5
MTMxcmRiLmR0c2kNCj4gYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL2JzYzkxMzJxZHMuZHRzaQ0KPiBh
cmNoL3Bvd2VycGMvYm9vdC9kdHMvcDEwMTByZGIuZHRzaQ0KPiBhcmNoL3Bvd2VycGMvYm9vdC9k
dHMvcDEwMjByZGItcGQuZHRzDQo+IGFyY2gvcG93ZXJwYy9ib290L2R0cy9wMTAyMXJkYi1wYy5k
dHNpDQo+IGFyY2gvcG93ZXJwYy9ib290L2R0cy9wMTAyMmRzLmR0c2kNCj4gYXJjaC9wb3dlcnBj
L2Jvb3QvZHRzL3AxMDI1dHdyLmR0c2kNCj4gYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL3AyMDIwcmRi
LXBjLmR0c2kNCj4gDQo+IFNpZ25lZC1vZmYtYnk6IFlhbmdibyBMdSA8eWFuZ2JvLmx1QGZyZWVz
Y2FsZS5jb20+DQo+IC0tLQ0KPiAgYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL2JzYzkxMzFyZGIuZHRz
aSAgfCAxMiArKysrKysrKysrKysgIA0KPiBhcmNoL3Bvd2VycGMvYm9vdC9kdHMvYnNjOTEzMnFk
cy5kdHNpICB8IDEyICsrKysrKysrKysrKw0KPiAgYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL3AxMDEw
cmRiLmR0c2kgICAgfCAxMiArKysrKysrKysrKysNCj4gIGFyY2gvcG93ZXJwYy9ib290L2R0cy9w
MTAyMHJkYi1wZC5kdHMgIHwgMTIgKysrKysrKysrKysrICANCj4gYXJjaC9wb3dlcnBjL2Jvb3Qv
ZHRzL3AxMDIxcmRiLXBjLmR0c2kgfCAxMiArKysrKysrKysrKysNCj4gIGFyY2gvcG93ZXJwYy9i
b290L2R0cy9wMTAyMmRzLmR0c2kgICAgIHwgMTIgKysrKysrKysrKysrDQo+ICBhcmNoL3Bvd2Vy
cGMvYm9vdC9kdHMvcDEwMjV0d3IuZHRzaSAgICB8IDEyICsrKysrKysrKysrKw0KPiAgYXJjaC9w
b3dlcnBjL2Jvb3QvZHRzL3AyMDIwcmRiLXBjLmR0c2kgfCAxNSArKysrKysrKystLS0tLS0NCj4g
IDggZmlsZXMgY2hhbmdlZCwgOTMgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkNCj4gDQo+
IGRpZmYgLS1naXQgYS9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvYnNjOTEzMXJkYi5kdHNpIA0KPiBi
L2FyY2gvcG93ZXJwYy9ib290L2R0cy9ic2M5MTMxcmRiLmR0c2kNCj4gaW5kZXggNDVlZmNiYS4u
NjI5Y2MwMyAxMDA2NDQNCj4gLS0tIGEvYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL2JzYzkxMzFyZGIu
ZHRzaQ0KPiArKysgYi9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvYnNjOTEzMXJkYi5kdHNpDQo+IEBA
IC04MCw2ICs4MCwxOCBAQA0KPiAgCQlzdGF0dXMgPSAiZGlzYWJsZWQiOw0KPiAgCX07DQo+ICAN
Cj4gKwlwdHBfY2xvY2tAYjBlMDAgew0KPiArCQljb21wYXRpYmxlID0gImZzbCxldHNlYy1wdHAi
Ow0KPiArCQlyZWcgPSA8MHhiMGUwMCAweGIwPjsNCj4gKwkJaW50ZXJydXB0cyA9IDw2OCAyIDAg
MCA2OSAyIDAgMD47DQo+ICsJCWZzbCx0Y2xrLXBlcmlvZAk9IDw1PjsNCj4gKwkJZnNsLHRtci1w
cnNjCT0gPDI+Ow0KPiArCQlmc2wsdG1yLWFkZAk9IDwweGNjY2NjY2NkPjsNCj4gKwkJZnNsLHRt
ci1maXBlcjEJPSA8MHgzYjlhYzlmYj47DQo+ICsJCWZzbCx0bXItZmlwZXIyCT0gPDB4MDAwMTg2
OTY+Ow0KPiArCQlmc2wsbWF4LWFkagk9IDwyNDk5OTk5OTk+Ow0KDQpQbGVhc2UgZG9uJ3QgdXNl
IGhleCBmb3IgbnVtYmVycyB0aGF0IG1ha2UgbW9yZSBzZW5zZSBhcyBkZWNpbWFsLg0KW0x1IFlh
bmdiby1CNDcwOTNdIFRoZSBoZXggdmFsdWUgaXMgcmVnaXN0ZXIgdmFsdWUsIEkgdGhpbmsgaXQn
cyBiZXR0ZXIgdG8gdXNlIGhleC4NCg0KPiAtLS0gYS9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvcDIw
MjByZGItcGMuZHRzaQ0KPiArKysgYi9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvcDIwMjByZGItcGMu
ZHRzaQ0KPiBAQCAtMjE1LDEyICsyMTUsMTUgQEANCj4gIAl9Ow0KPiAgDQo+ICAJcHRwX2Nsb2Nr
QDI0ZTAwIHsNCj4gLQkJZnNsLHRjbGstcGVyaW9kID0gPDU+Ow0KPiAtCQlmc2wsdG1yLXByc2Mg
PSA8MjAwPjsNCj4gLQkJZnNsLHRtci1hZGQgPSA8MHhDQ0NDQ0NDRD47DQo+IC0JCWZzbCx0bXIt
ZmlwZXIxID0gPDB4M0I5QUM5RkI+Ow0KPiAtCQlmc2wsdG1yLWZpcGVyMiA9IDwweDAwMDE4NjlC
PjsNCj4gLQkJZnNsLG1heC1hZGogPSA8MjQ5OTk5OTk5PjsNCj4gKwkJY29tcGF0aWJsZSA9ICJm
c2wsZXRzZWMtcHRwIjsNCj4gKwkJcmVnID0gPDB4MjRlMDAgMHhiMD47DQo+ICsJCWludGVycnVw
dHMgPSA8NjggMiAwIDAgNjkgMiAwIDA+Ow0KPiArCQlmc2wsdGNsay1wZXJpb2QJPSA8NT47DQo+
ICsJCWZzbCx0bXItcHJzYwk9IDwyPjsNCj4gKwkJZnNsLHRtci1hZGQJPSA8MHhhYWFhYWFhYj47
DQo+ICsJCWZzbCx0bXItZmlwZXIxCT0gPDB4M2I5YWM5ZmI+Ow0KPiArCQlmc2wsdG1yLWZpcGVy
Mgk9IDwweDAwMDE4Njk2PjsNCj4gKwkJZnNsLG1heC1hZGoJPSA8Mjk5OTk5OTk5PjsNCj4gIAl9
Ow0KDQpUaGlzIGlzbid0IGFkZGluZyBhIG5vZGUgLS0gaXQncyBjaGFuZ2luZyB2YWx1ZXMuICBJ
ZiB0aGUgb2xkIG9uZXMgd2VyZSB3cm9uZywgZXhwbGFpbiB0aGF0IGluIHRoZSBjaGFuZ2Vsb2cu
DQoNCkFsc28sIHAyMDIwc2ktcG9zdC5kdHNpIGFscmVhZHkgYWRkcyBpbnRlcnJ1cHRzIHRvIHRo
aXMgbm9kZSAoYW5kIGl0IGNvbnRhaW5zIG9uZSBtb3JlIGludGVycnVwdCB0aGFuIHRoZSBhYm92
ZSksIGFuZCBpdCBpbmNsdWRlcyBwcTMtZXRzZWMxLXRpbWVyLTAuZHRzaSB3aGljaCBjb250YWlu
cyB0aGUgY29tcGF0aWJsZSBhbmQgcmVnIChhbmQgaW50ZXJydXB0cyB3aXRoIHR3byBzcGVjaWZp
ZXJzKS4gIFByb2JhYmx5IGFsbCBvZiB0aGVzZSBzaG91bGQgYmUgdXNpbmcgcHEzLWV0c2VjMS10
aW1lci0wLmR0c2kgYW5kIG9ubHkgc3BlY2lmeWluZyB0aGUgYm9hcmQtc3BlY2lmaWMgdmFsdWVz
Lg0KDQpbTHUgWWFuZ2JvLUI0NzA5M10gSSB3aWxsIG1vZGlmeSBhY2NvcmRpbmcgeW91ciBjb21t
ZW50cyBoZXJlLg0KDQotU2NvdHQNCg0KDQo=
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/dts: Add 1588 timer node for eTSEC
2015-05-07 2:26 ` yangbo.lu
@ 2015-05-07 2:34 ` Scott Wood
2015-05-07 2:49 ` yangbo.lu
0 siblings, 1 reply; 5+ messages in thread
From: Scott Wood @ 2015-05-07 2:34 UTC (permalink / raw)
To: Lu Yangbo-B47093
Cc: linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
On Wed, 2015-05-06 at 21:26 -0500, Lu Yangbo-B47093 wrote:
> Thanks.
> Pls see my comments below.
>
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Thursday, May 07, 2015 4:44 AM
> To: Lu Yangbo-B47093
> Cc: linuxppc-dev@lists•ozlabs.org; linux-kernel@vger•kernel.org
> Subject: Re: [PATCH] powerpc/dts: Add 1588 timer node for eTSEC
>
> On Wed, 2015-05-06 at 17:40 +0800, Yangbo Lu wrote:
> > Add 1588 timer node in files:
> > arch/powerpc/boot/dts/bsc9131rdb.dtsi
> > arch/powerpc/boot/dts/bsc9132qds.dtsi
> > arch/powerpc/boot/dts/p1010rdb.dtsi
> > arch/powerpc/boot/dts/p1020rdb-pd.dts
> > arch/powerpc/boot/dts/p1021rdb-pc.dtsi
> > arch/powerpc/boot/dts/p1022ds.dtsi
> > arch/powerpc/boot/dts/p1025twr.dtsi
> > arch/powerpc/boot/dts/p2020rdb-pc.dtsi
> >
> > Signed-off-by: Yangbo Lu <yangbo.lu@freescale•com>
> > ---
> > arch/powerpc/boot/dts/bsc9131rdb.dtsi | 12 ++++++++++++
> > arch/powerpc/boot/dts/bsc9132qds.dtsi | 12 ++++++++++++
> > arch/powerpc/boot/dts/p1010rdb.dtsi | 12 ++++++++++++
> > arch/powerpc/boot/dts/p1020rdb-pd.dts | 12 ++++++++++++
> > arch/powerpc/boot/dts/p1021rdb-pc.dtsi | 12 ++++++++++++
> > arch/powerpc/boot/dts/p1022ds.dtsi | 12 ++++++++++++
> > arch/powerpc/boot/dts/p1025twr.dtsi | 12 ++++++++++++
> > arch/powerpc/boot/dts/p2020rdb-pc.dtsi | 15 +++++++++------
> > 8 files changed, 93 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/powerpc/boot/dts/bsc9131rdb.dtsi
> > b/arch/powerpc/boot/dts/bsc9131rdb.dtsi
> > index 45efcba..629cc03 100644
> > --- a/arch/powerpc/boot/dts/bsc9131rdb.dtsi
> > +++ b/arch/powerpc/boot/dts/bsc9131rdb.dtsi
> > @@ -80,6 +80,18 @@
> > status = "disabled";
> > };
> >
> > + ptp_clock@b0e00 {
> > + compatible = "fsl,etsec-ptp";
> > + reg = <0xb0e00 0xb0>;
> > + interrupts = <68 2 0 0 69 2 0 0>;
> > + fsl,tclk-period = <5>;
> > + fsl,tmr-prsc = <2>;
> > + fsl,tmr-add = <0xcccccccd>;
> > + fsl,tmr-fiper1 = <0x3b9ac9fb>;
> > + fsl,tmr-fiper2 = <0x00018696>;
> > + fsl,max-adj = <249999999>;
>
> Please don't use hex for numbers that make more sense as decimal.
> [Lu Yangbo-B47093] The hex value is register value, I think it's better to use hex.
Whether it goes into a register doesn't matter. Hex values are useful
for values which are subdivided into various bitfields, or whose hex
representation is simpler than decimal. I'm not familiar with the
details of this hardware, but I doubt the former is the case for
0x3b9ac9fb == 9999999995 or 0x18696 == 99990.
-Scott
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] powerpc/dts: Add 1588 timer node for eTSEC
2015-05-07 2:34 ` Scott Wood
@ 2015-05-07 2:49 ` yangbo.lu
0 siblings, 0 replies; 5+ messages in thread
From: yangbo.lu @ 2015-05-07 2:49 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBXb29kIFNjb3R0LUIwNzQyMSAN
ClNlbnQ6IFRodXJzZGF5LCBNYXkgMDcsIDIwMTUgMTA6MzUgQU0NClRvOiBMdSBZYW5nYm8tQjQ3
MDkzDQpDYzogbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IGxpbnV4LWtlcm5lbEB2Z2Vy
Lmtlcm5lbC5vcmcNClN1YmplY3Q6IFJlOiBbUEFUQ0hdIHBvd2VycGMvZHRzOiBBZGQgMTU4OCB0
aW1lciBub2RlIGZvciBlVFNFQw0KDQpPbiBXZWQsIDIwMTUtMDUtMDYgYXQgMjE6MjYgLTA1MDAs
IEx1IFlhbmdiby1CNDcwOTMgd3JvdGU6DQo+IFRoYW5rcy4NCj4gUGxzIHNlZSBteSBjb21tZW50
cyBiZWxvdy4NCj4gDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFdvb2Qg
U2NvdHQtQjA3NDIxDQo+IFNlbnQ6IFRodXJzZGF5LCBNYXkgMDcsIDIwMTUgNDo0NCBBTQ0KPiBU
bzogTHUgWWFuZ2JvLUI0NzA5Mw0KPiBDYzogbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7
IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSF0gcG93
ZXJwYy9kdHM6IEFkZCAxNTg4IHRpbWVyIG5vZGUgZm9yIGVUU0VDDQo+IA0KPiBPbiBXZWQsIDIw
MTUtMDUtMDYgYXQgMTc6NDAgKzA4MDAsIFlhbmdibyBMdSB3cm90ZToNCj4gPiBBZGQgMTU4OCB0
aW1lciBub2RlIGluIGZpbGVzOg0KPiA+IGFyY2gvcG93ZXJwYy9ib290L2R0cy9ic2M5MTMxcmRi
LmR0c2kNCj4gPiBhcmNoL3Bvd2VycGMvYm9vdC9kdHMvYnNjOTEzMnFkcy5kdHNpDQo+ID4gYXJj
aC9wb3dlcnBjL2Jvb3QvZHRzL3AxMDEwcmRiLmR0c2kNCj4gPiBhcmNoL3Bvd2VycGMvYm9vdC9k
dHMvcDEwMjByZGItcGQuZHRzDQo+ID4gYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL3AxMDIxcmRiLXBj
LmR0c2kNCj4gPiBhcmNoL3Bvd2VycGMvYm9vdC9kdHMvcDEwMjJkcy5kdHNpDQo+ID4gYXJjaC9w
b3dlcnBjL2Jvb3QvZHRzL3AxMDI1dHdyLmR0c2kNCj4gPiBhcmNoL3Bvd2VycGMvYm9vdC9kdHMv
cDIwMjByZGItcGMuZHRzaQ0KPiA+IA0KPiA+IFNpZ25lZC1vZmYtYnk6IFlhbmdibyBMdSA8eWFu
Z2JvLmx1QGZyZWVzY2FsZS5jb20+DQo+ID4gLS0tDQo+ID4gIGFyY2gvcG93ZXJwYy9ib290L2R0
cy9ic2M5MTMxcmRiLmR0c2kgIHwgMTIgKysrKysrKysrKysrIA0KPiA+IGFyY2gvcG93ZXJwYy9i
b290L2R0cy9ic2M5MTMycWRzLmR0c2kgIHwgMTIgKysrKysrKysrKysrDQo+ID4gIGFyY2gvcG93
ZXJwYy9ib290L2R0cy9wMTAxMHJkYi5kdHNpICAgIHwgMTIgKysrKysrKysrKysrDQo+ID4gIGFy
Y2gvcG93ZXJwYy9ib290L2R0cy9wMTAyMHJkYi1wZC5kdHMgIHwgMTIgKysrKysrKysrKysrIA0K
PiA+IGFyY2gvcG93ZXJwYy9ib290L2R0cy9wMTAyMXJkYi1wYy5kdHNpIHwgMTIgKysrKysrKysr
KysrDQo+ID4gIGFyY2gvcG93ZXJwYy9ib290L2R0cy9wMTAyMmRzLmR0c2kgICAgIHwgMTIgKysr
KysrKysrKysrDQo+ID4gIGFyY2gvcG93ZXJwYy9ib290L2R0cy9wMTAyNXR3ci5kdHNpICAgIHwg
MTIgKysrKysrKysrKysrDQo+ID4gIGFyY2gvcG93ZXJwYy9ib290L2R0cy9wMjAyMHJkYi1wYy5k
dHNpIHwgMTUgKysrKysrKysrLS0tLS0tDQo+ID4gIDggZmlsZXMgY2hhbmdlZCwgOTMgaW5zZXJ0
aW9ucygrKSwgNiBkZWxldGlvbnMoLSkNCj4gPiANCj4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9wb3dl
cnBjL2Jvb3QvZHRzL2JzYzkxMzFyZGIuZHRzaQ0KPiA+IGIvYXJjaC9wb3dlcnBjL2Jvb3QvZHRz
L2JzYzkxMzFyZGIuZHRzaQ0KPiA+IGluZGV4IDQ1ZWZjYmEuLjYyOWNjMDMgMTAwNjQ0DQo+ID4g
LS0tIGEvYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL2JzYzkxMzFyZGIuZHRzaQ0KPiA+ICsrKyBiL2Fy
Y2gvcG93ZXJwYy9ib290L2R0cy9ic2M5MTMxcmRiLmR0c2kNCj4gPiBAQCAtODAsNiArODAsMTgg
QEANCj4gPiAgCQlzdGF0dXMgPSAiZGlzYWJsZWQiOw0KPiA+ICAJfTsNCj4gPiAgDQo+ID4gKwlw
dHBfY2xvY2tAYjBlMDAgew0KPiA+ICsJCWNvbXBhdGlibGUgPSAiZnNsLGV0c2VjLXB0cCI7DQo+
ID4gKwkJcmVnID0gPDB4YjBlMDAgMHhiMD47DQo+ID4gKwkJaW50ZXJydXB0cyA9IDw2OCAyIDAg
MCA2OSAyIDAgMD47DQo+ID4gKwkJZnNsLHRjbGstcGVyaW9kCT0gPDU+Ow0KPiA+ICsJCWZzbCx0
bXItcHJzYwk9IDwyPjsNCj4gPiArCQlmc2wsdG1yLWFkZAk9IDwweGNjY2NjY2NkPjsNCj4gPiAr
CQlmc2wsdG1yLWZpcGVyMQk9IDwweDNiOWFjOWZiPjsNCj4gPiArCQlmc2wsdG1yLWZpcGVyMgk9
IDwweDAwMDE4Njk2PjsNCj4gPiArCQlmc2wsbWF4LWFkagk9IDwyNDk5OTk5OTk+Ow0KPiANCj4g
UGxlYXNlIGRvbid0IHVzZSBoZXggZm9yIG51bWJlcnMgdGhhdCBtYWtlIG1vcmUgc2Vuc2UgYXMg
ZGVjaW1hbC4NCj4gW0x1IFlhbmdiby1CNDcwOTNdIFRoZSBoZXggdmFsdWUgaXMgcmVnaXN0ZXIg
dmFsdWUsIEkgdGhpbmsgaXQncyBiZXR0ZXIgdG8gdXNlIGhleC4NCg0KV2hldGhlciBpdCBnb2Vz
IGludG8gYSByZWdpc3RlciBkb2Vzbid0IG1hdHRlci4gIEhleCB2YWx1ZXMgYXJlIHVzZWZ1bCBm
b3IgdmFsdWVzIHdoaWNoIGFyZSBzdWJkaXZpZGVkIGludG8gdmFyaW91cyBiaXRmaWVsZHMsIG9y
IHdob3NlIGhleCByZXByZXNlbnRhdGlvbiBpcyBzaW1wbGVyIHRoYW4gZGVjaW1hbC4gIEknbSBu
b3QgZmFtaWxpYXIgd2l0aCB0aGUgZGV0YWlscyBvZiB0aGlzIGhhcmR3YXJlLCBidXQgSSBkb3Vi
dCB0aGUgZm9ybWVyIGlzIHRoZSBjYXNlIGZvciAweDNiOWFjOWZiID09IDk5OTk5OTk5OTUgb3Ig
MHgxODY5NiA9PSA5OTk5MC4NCltMdSBZYW5nYm8tQjQ3MDkzXSBUaGFua3MgU2NvdHQuIEkgZ290
IGl0LiBUaGUgaGV4IHZhbHVlIGhlcmUgaXMgbm90IGZvciB2YXJpb3VzIGJpdGZpZWxkcyBidXQg
YSB2YWx1ZSBjYWxjdWxhdGVkIG1hbnVhbGx5LiBJIHdpbGwgbW9kaWZ5IHRvIGRlY2ltYWxpc20u
DQoNCi1TY290dA0KDQoNCg==
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-05-07 3:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-06 9:40 [PATCH] powerpc/dts: Add 1588 timer node for eTSEC Yangbo Lu
2015-05-06 20:44 ` Scott Wood
2015-05-07 2:26 ` yangbo.lu
2015-05-07 2:34 ` Scott Wood
2015-05-07 2:49 ` yangbo.lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox