From: Dan DeVoto <dand1972@yahoo•com>
To: wsa@the-dreams•de, Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: Mark Elliott <txlitebeer@gmail•com>,
linuxppc-dev@lists•ozlabs.org, linux-i2c@vger•kernel.org
Subject: Re: [PATCH] i2c: powermac: don't workaround for keywest
Date: Sun, 17 May 2015 01:40:07 -0700 [thread overview]
Message-ID: <1431852007.81598.YahooMailBasic@web141505.mail.bf1.yahoo.com> (raw)
In-Reply-To: <1431386803.13039.30.camel@kernel.crashing.org>
Hi,
Sorry for the delay, I found this message in my spam folder. Anyway,
for my machine model, cat /proc/device-tree/compatible returns:
PowerBook4,3MacRISC2MacRISCPower Macintosh
It's a 14 in. iBook G3 700 MHz.
Regards,
Dan
--------------------------------------------
On Mon, 5/11/15, Benjamin Herrenschmidt <benh@kernel•crashing.org> wrote:
Subject: Re: [PATCH] i2c: powermac: don't workaround for keywest
To: wsa@the-dreams•de
Cc: linux-i2c@vger•kernel.org, linuxppc-dev@lists•ozlabs.org, "Dan DeVoto" <dand1972@yahoo•com>, "Mark Elliott" <txlitebeer@gmail•com>
Date: Monday, May 11, 2015, 4:26 PM
On Mon, 2015-05-11 at 09:34 +0200, wsa@the-dreams•de wrote:
> On Mon, May 11, 2015 at 08:14:47AM +1000, Benjamin Herrenschmidt wrote:
> > On Sun, 2015-05-10 at 20:34 +0200, Wolfram Sang wrote:
> > > Okay, so this patch is bogus. I understand now that onyx uses another
> > > codec than TAS, so this change will regress on other machines.
> > > However,
> > > it shows that this unconditional instantiation of the TAS breaks sound
> > > on Macintoshs which still need non-aoa sound support. I assume there
> > > will be noone in the near future to convert Keywest to AOA, so we'll
> > > need to find a hackish way around this instantiation problem.
> >
> > Converting the old macs that use TAS shouldn't be *that* hard, main
> > problem is I don't have the hardware to test...
> > Dan and Mark (on CC) have been very helpful with testing. Maybe they are
> > also in to test "the proper solution"?
> Possibly, depends how many machines we can cover. I also have extremely
> little time, so I'm not that keen on volunteering :-) I'll *try* to have
> a look some time this or next week.
>
> The main problem is the difference in the way the layout of the codec
> etc... is reported from the DT by the firmware. Otherwise the HW is the
> same between pre-AOA and post-AOA really ...
>
> I do have a bunch of DT snapshots lying around, so I can try
> to figure out something.
>
> Dan, Mark, what machine models specifically do you have ? (compatible
> property in the DT pls, ie, /proc/device-tree/compatible).
>
> Cheers,
> Ben.
prev parent reply other threads:[~2015-05-17 8:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 17:23 [PATCH] i2c: powermac: don't workaround for keywest Wolfram Sang
2015-05-10 18:34 ` Wolfram Sang
2015-05-10 22:14 ` Benjamin Herrenschmidt
2015-05-11 7:34 ` wsa
2015-05-11 23:26 ` Benjamin Herrenschmidt
2015-05-17 8:40 ` Dan DeVoto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431852007.81598.YahooMailBasic@web141505.mail.bf1.yahoo.com \
--to=dand1972@yahoo$(echo .)com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=txlitebeer@gmail$(echo .)com \
--cc=wsa@the-dreams$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox