Subject: Re: [PATCH 1/2] qe_common: add qe common functions into qe_common.c

From: Scott Wood <[email-masked]>
Date: Wed, 27 May 2015 17:51:14 -0500

On Wed, 2015-05-27 at 17:11 +0800, Zhao Qiang wrote:
> +int qe_muram_init(void)
> +{
> +     struct device_node *np;
> +     struct resource r;
> +     u32 zero[OF_MAX_ADDR_CELLS] = {};
> +     resource_size_t max = 0;
> +     int i = 0;
> +     int ret = 0;
> +
> +     if (muram_pbase)
> +             return 0;
> +
> +     spin_lock_init(&qe_muram_lock);
> +     /* initialize the info header */
> +     rh_init(&qe_muram_info, 1,
> +             sizeof(qe_boot_muram_rh_block) /
> +             sizeof(qe_boot_muram_rh_block[0]),
> +             qe_boot_muram_rh_block);

NACK (see patch 2/2), and even if rheap were acceptable that would 
have needed to come before patches using it outside arch/powerpc.

-Scott