Subject: Re: [PATCH v1 1/9]powerpc/powernv: Data structure and macros definition

From: Daniel Axtens <[email-masked]>
Date: Wed, 03 Jun 2015 09:11:03 +1000

> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; either version
> + * 2 of the License, or (at your option) any later version.
> + */

I'm not certain about this, but I _think_ this is supposed to be version
2 only:
http://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/COPYING#n9

> +/*
> + * Device tree parser code detect nest pmu support
> + * and create new nest pmus. This structure will
> + * hold the pmu functions and attrs for each nest pmu and
> + * will be referenced at the time of pmu registering.
> + */

The first sentence of that comment is unclear: I think your trying to
say "Device tree parser code detects nest pmu support and registers new
nest pmus"? Also s/registering/registration/.

> +struct nest_pmu {
> +	struct pmu pmu;
> +	const struct attribute_group *attr_groups[4];
> +};
> +

Regards,
Daniel Axtens