From: Daniel Axtens <dja@axtens•net>
To: Anshuman Khandual <khandual@linux•vnet.ibm.com>
Cc: linuxppc-dev@ozlabs•org, mikey@neuling•org, sukadev@linux•vnet.ibm.com
Subject: Re: [PATCH V8 06/10] powerpc, lib: Add new branch analysis support functions
Date: Wed, 10 Jun 2015 15:33:11 +1000 [thread overview]
Message-ID: <1433914391.3096.40.camel@axtens.net> (raw)
In-Reply-To: <1433763511-5270-6-git-send-email-khandual@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1410 bytes --]
> +static int instr_is_branch_xlform(unsigned int instr)
> +{
> + return branch_opcode(instr) == 19;
> +}
Why do these not return bool? The functions below do.
> +
> +static int is_xlform_lr(unsigned int instr)
> +{
> + return (instr & XL_FORM_LR) == XL_FORM_LR;
> +}
> +
> +static int is_bo_always(unsigned int instr)
> +{
> + return (instr & BO_ALWAYS) == BO_ALWAYS;
> +}
> +
> +static int is_branch_link_set(unsigned int instr)
> +{
> + return (instr & BRANCH_SET_LINK) == BRANCH_SET_LINK;
> +}
> +
> +bool instr_is_return_branch(unsigned int instr)
> +{
> + /*
> + * Conditional and unconditional branch to LR register
> + * without seting the link register.
setting
> + */
> + if (is_xlform_lr(instr) && !is_branch_link_set(instr))
> + return true;
> +
> + return false;
> +}
> +
> +bool instr_is_func_call(unsigned int instr)
> +{
> + /* LR should be set */
> + if (is_branch_link_set(instr))
> + return true;
> +
> + return false;
> +}
> +
> +bool instr_is_indirect_func_call(unsigned int instr)
> +{
> + /* XL-form instruction with LR set */
> + if (instr_is_branch_xlform(instr) && is_branch_link_set(instr))
> + return true;
> +
> + return false;
> +}
Both of these functions could be made into a single 'return' statement,
right?
> +
> int instr_is_relative_branch(unsigned int instr)
> {
> if (instr & BRANCH_ABSOLUTE)
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 860 bytes --]
next prev parent reply other threads:[~2015-06-10 5:34 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 11:38 [PATCH V8 01/10] powerpc, perf: Drop the branch sample when 'from' cannot be fetched Anshuman Khandual
2015-06-08 11:38 ` [PATCH V8 02/10] powerpc, perf: Restore privillege level filter support for BHRB Anshuman Khandual
2015-06-10 3:43 ` Daniel Axtens
2015-06-10 12:08 ` Anshuman Khandual
2015-06-11 3:28 ` Daniel Axtens
2015-06-12 7:06 ` Anshuman Khandual
2015-06-08 11:38 ` [PATCH V8 03/10] powerpc, perf: Re organize BHRB processing Anshuman Khandual
2015-06-10 4:36 ` Daniel Axtens
2015-06-10 12:09 ` Anshuman Khandual
2015-06-11 3:32 ` Daniel Axtens
2015-06-12 7:05 ` Anshuman Khandual
2015-06-08 11:38 ` [PATCH V8 04/10] powerpc, perf: Re organize PMU based branch filter processing in POWER8 Anshuman Khandual
2015-06-10 5:07 ` Daniel Axtens
2015-06-10 12:09 ` Anshuman Khandual
2015-06-08 11:38 ` [PATCH V8 05/10] powerpc, perf: Change the name of HW PMU branch filter tracking variable Anshuman Khandual
2015-06-08 11:38 ` [PATCH V8 06/10] powerpc, lib: Add new branch analysis support functions Anshuman Khandual
2015-06-10 5:33 ` Daniel Axtens [this message]
2015-06-10 12:10 ` Anshuman Khandual
2015-06-08 11:38 ` [PATCH V8 07/10] powerpc, perf: Enable SW filtering in branch stack sampling framework Anshuman Khandual
2015-06-08 11:38 ` [PATCH V8 08/10] powerpc, perf: Change POWER8 PMU configuration to work with SW filters Anshuman Khandual
2015-06-10 5:49 ` Daniel Axtens
2015-06-10 12:10 ` Anshuman Khandual
2015-06-11 3:38 ` Daniel Axtens
2015-06-08 11:38 ` [PATCH V8 09/10] powerpc, perf: Enable privilege mode SW branch filters Anshuman Khandual
2015-06-11 1:19 ` Daniel Axtens
2015-06-12 7:04 ` Anshuman Khandual
2015-06-08 11:38 ` [PATCH V8 10/10] selftests, powerpc: Add test for BHRB branch filters (HW & SW) Anshuman Khandual
2015-06-09 5:41 ` Anshuman Khandual
2015-06-11 2:09 ` Daniel Axtens
2015-06-12 7:02 ` Anshuman Khandual
2015-06-12 7:26 ` Madhavan Srinivasan
2015-06-12 8:59 ` Anshuman Khandual
2015-06-10 3:21 ` [PATCH V8 01/10] powerpc, perf: Drop the branch sample when 'from' cannot be fetched Daniel Axtens
2015-06-10 12:02 ` Anshuman Khandual
2015-06-11 2:22 ` Daniel Axtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433914391.3096.40.camel@axtens.net \
--to=dja@axtens$(echo .)net \
--cc=khandual@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mikey@neuling$(echo .)org \
--cc=sukadev@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox