Subject: Re: [PATCH V2] QorIQ/TMU: add TMU node to device tree for QorIQ T104x

From: Scott Wood <[email-masked]>
Date: Wed, 10 Jun 2015 13:37:29 -0500

On Wed, 2015-06-10 at 03:56 -0500, Jia Hongtao-B38951 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Wednesday, June 10, 2015 1:47 AM
> > To: Jia Hongtao-B38951
> > Cc: [email-masked]; [email-masked];
> > [email-masked]; [email-masked]; [email-masked]
> > Subject: Re: [PATCH V2] QorIQ/TMU: add TMU node to device tree for 
> > QorIQ
> > T104x
> > 
> > On Mon, 2015-06-08 at 21:19 -0500, Jia Hongtao-B38951 wrote:
> > > > -----Original Message-----
> > > > From: Wood Scott-B07421
> > > > Sent: Wednesday, May 27, 2015 3:38 AM
> > > > To: Jia Hongtao-B38951
> > > > Cc: [email-masked]; [email-masked];
> > > > [email-masked]; [email-masked]; 
> > > > [email-masked]
> > > > Subject: Re: [PATCH V2] QorIQ/TMU: add TMU node to device tree 
> > > > for
> > > > QorIQ T104x
> > > > 
> > > > On Tue, 2015-05-26 at 01:33 -0500, Jia Hongtao-B38951 wrote:
> > > > > diff --git a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> > > > > > b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> > > > > > index 15ae462..bb9f792 100644
> > > > > > --- a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> > > > > > +++ b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
> > > > > > @@ -345,6 +345,7 @@
> > > > > >             reg        = <0xea000 0x4000>;
> > > > > >     };
> > > > > > 
> > > > > > +/include/ "qoriq-tmu-t104xsi.dtsi"
> > > > > >  /include/ "elo3-dma-0.dtsi"
> > > > > >  /include/ "elo3-dma-1.dtsi"
> > > > > >  /include/ "qoriq-espi-0.dtsi"
> > > > 
> > > > Why is this chip-specific enough to be called "t104xsi", but 
> > > > not
> > > > chip-
> > > > specific enough to just go directly into t1040si-post?
> 
> The tmu node includes lots of contents.
> Is it looks messy if just go directly into t1040si-post?

I don't think it's too much to go into the main file.  Having too many 
files is a hassle as well...

-Scott