Subject: Re: question on FSL_EMB perf

From: Peter Zijlstra <[email-masked]>
Date: Wed, 10 Jun 2015 21:27:34 +0200

On Wed, 2015-06-10 at 14:17 -0500, Scott Wood wrote:
> On Wed, 2015-06-10 at 13:41 +0200, Peter Zijlstra wrote:
> > Hi Mike, Ben,
> >=20
> > I just noticed:
> >=20
> > arch/powerpc/Kconfig:   select HAVE_PERF_EVENTS_NMI if PPC64
> >=20
> > But can't ppc32 have FSL_EMB perf?
>=20
> Yes, but it doesn't use NMIs.  ppc64 has lazy interrupt disabling=20
> which functions as a pseudo-NMI.

I know. But you can get the same nesting nonsense as with actual real
NMIs.

And seeing how you select HAVE_PERF_EVENT_NMI for PPC64, I figure you
ought to select it too for whatever fsl-emb is.

# git grep nmi_enter arch/powerpc/
arch/powerpc/perf/core-book3s.c:                nmi_enter();
arch/powerpc/perf/core-fsl-emb.c:               nmi_enter();