From: Michael Ellerman <mpe@ellerman•id.au>
To: Michael Neuling <mikey@neuling•org>
Cc: benh <benh@kernel•crashing.org>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
Ian Munsie <ianmunsi@au1•ibm.com>
Subject: Re: [PATCH] cxl: Fix typo in debug print
Date: Thu, 18 Jun 2015 15:57:44 +1000 [thread overview]
Message-ID: <1434607064.25157.2.camel@ellerman.id.au> (raw)
In-Reply-To: <1434604510.2942.33.camel@neuling.org>
On Thu, 2015-06-18 at 15:15 +1000, Michael Neuling wrote:
> Fix typo in debug print. p1->p2. No functional change.
That's not "no functional change", it changes the behaviour, unless p2_base()
implements the same logic as p1_base()?
cheers
> diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
> index 1ef0164..8515791 100644
> --- a/drivers/misc/cxl/pci.c
> +++ b/drivers/misc/cxl/pci.c
> @@ -204,7 +204,7 @@ static void dump_cxl_config_space(struct pci_dev *dev)
> dev_info(&dev->dev, "p1 regs: %#llx, len: %#llx\n",
> p1_base(dev), p1_size(dev));
> dev_info(&dev->dev, "p2 regs: %#llx, len: %#llx\n",
> - p1_base(dev), p2_size(dev));
> + p2_base(dev), p2_size(dev));
> dev_info(&dev->dev, "BAR 4/5: %#llx, len: %#llx\n",
> pci_resource_start(dev, 4), pci_resource_len(dev, 4));
>
>
>
next prev parent reply other threads:[~2015-06-18 5:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 5:15 [PATCH] cxl: Fix typo in debug print Michael Neuling
2015-06-18 5:30 ` Ian Munsie
2015-06-18 5:57 ` Michael Ellerman [this message]
2015-06-18 6:12 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434607064.25157.2.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=benh@kernel$(echo .)crashing.org \
--cc=ianmunsi@au1$(echo .)ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mikey@neuling$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox