Subject: Re: [PATCH] cxl: Fix typo in debug print

From: Michael Neuling <[email-masked]>
Date: Thu, 18 Jun 2015 16:12:07 +1000

On Thu, 2015-06-18 at 15:57 +1000, Michael Ellerman wrote:
> On Thu, 2015-06-18 at 15:15 +1000, Michael Neuling wrote:
> > Fix typo in debug print.  p1->p2.  No functional change.
> 
> That's not "no functional change", it changes the behaviour, unless p2_base()
> implements the same logic as p1_base()?

Maybe I should change it to "Only debug output printing change"?

Mikey

> 
> cheers
> 
> > diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
> > index 1ef0164..8515791 100644
> > --- a/drivers/misc/cxl/pci.c
> > +++ b/drivers/misc/cxl/pci.c
> > @@ -204,7 +204,7 @@ static void dump_cxl_config_space(struct pci_dev *dev)
> >  	dev_info(&dev->dev, "p1 regs: %#llx, len: %#llx\n",
> >  		p1_base(dev), p1_size(dev));
> >  	dev_info(&dev->dev, "p2 regs: %#llx, len: %#llx\n",
> > -		p1_base(dev), p2_size(dev));
> > +		p2_base(dev), p2_size(dev));
> >  	dev_info(&dev->dev, "BAR 4/5: %#llx, len: %#llx\n",
> >  		pci_resource_start(dev, 4), pci_resource_len(dev, 4));
> >  
> > 
> > 
> 
> 
> 
>