From: Michael Ellerman <mpe@ellerman•id.au>
To: David Long <dave.long@linaro•org>
Cc: "H. Peter Anvin" <hpa@zytor•com>,
Andy Lutomirski <luto@amacapital•net>,
Anton Blanchard <anton@samba•org>,
Behan Webster <behanw@converseincode•com>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Eric Paris <eparis@redhat•com>,
Heiko Carstens <heiko.carstens@de•ibm.com>,
Ingo Molnar <mingo@redhat•com>, Jan Willeke <willeke@de•ibm.com>,
Kees Cook <keescook@chromium•org>,
Martin Schwidefsky <schwidefsky@de•ibm.com>,
Nikolay Borisov <Nikolay.Borisov@arm•com>,
Oleg Nesterov <oleg@redhat•com>,
Paul Mackerras <paulus@samba•org>,
Richard Kuo <rkuo@codeaurora•org>,
Robert Richter <rric@kernel•org>,
Roland McGrath <roland@hack•frob.com>,
Russell King <linux@arm•linux.org.uk>, Tejun Heo <tj@kernel•org>,
Thomas Gleixner <tglx@linutronix•de>,
Will Deacon <will.deacon@arm•com>,
linux-arm-kernel@lists•infradead.org,
linux-hexagon@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-s390@vger•kernel.org, linux-sh@vger•kernel.org,
linux390@de•ibm.com, linuxppc-dev@lists•ozlabs.org,
x86@kernel•org, mahesh@linux•vnet.ibm.com
Subject: Re: [PATCH 1/2] Move the pt_regs_offset struct definition from arch to common include file
Date: Tue, 23 Jun 2015 13:32:08 +1000 [thread overview]
Message-ID: <1435030328.28070.5.camel@ellerman.id.au> (raw)
In-Reply-To: <5584234E.2040701@linaro.org>
On Fri, 2015-06-19 at 10:12 -0400, David Long wrote:
> On 06/19/15 00:19, Michael Ellerman wrote:
> > On Mon, 2015-06-15 at 12:42 -0400, David Long wrote:
> >> From: "David A. Long" <dave.long@linaro•org>
> >>
> >> The pt_regs_offset structure is used for HAVE_REGS_AND_STACK_ACCESS_API
> >> feature and has identical definitions in four different arch ptrace.h
> >> include files. It seems unlikely that definition would ever need to be
> >> changed regardless of architecture so lets move it into
> >> include/linux/ptrace.h.
> >>
> >> Signed-off-by: David A. Long <dave.long@linaro•org>
> >> ---
> >> arch/powerpc/kernel/ptrace.c | 5 -----
> >
> > Built and booted on powerpc, but is there an easy way to actually test the code
> > paths in question?
> >
>
> There is an easy way to "smoke test" it on all archiectures that also
> implement kprobes (which powerpc does). If I'm understanding the
> powerpc code correctly (WRT register naming conventions) just do the
> following:
>
> cd /sys/kernel/debug/tracing
> echo 'p do_fork %gpr0' > kprobe_events
> echo 1 > events/kprobes/enable
> ls
> cat trace
> echo 0 > events/kprobes/enable
>
> Every fork() call done on the system between those two echo commands
> (hence the "ls") should append a line to the trace file. For a more
> exhaustive test one could repeat this sequence for every register in the
> architecture.
OK, so I went the whole hog and did:
$ echo 'p do_fork %gpr0 %gpr1 %gpr2 %gpr3 %gpr4 %gpr5 %gpr6 %gpr7 %gpr8 %gpr9 %gpr10 %gpr11 %gpr12 %gpr13 %gpr14 %gpr15 %gpr16 %gpr17 %gpr18 %gpr19 %gpr20 %gpr21 %gpr22 %gpr23 %gpr24 %gpr25 %gpr26 %gpr27 %gpr28 %gpr29 %gpr30 %gpr31 %nip %msr %ctr %link %xer %ccr %softe %trap %dar %dsisr' > kprobe_events
And I get:
bash-2057 [001] d... 535.433941: p_do_fork_0: (do_fork+0x8/0x490) arg1=0xc0000000000094d0 arg2=0xc0000001fbe9be30 arg3=0xc000000001133bb8 arg4=0x1200011 arg5=0x0 arg6=0x0 arg7=0x0 arg8=0x3fff7c885940 arg9=0x1 arg10=0xc0000001fbe9bea0 arg11=0x0 arg12=0xc01 arg13=0xc0000000000094c8 arg14=0xc00000000fdc0480 arg15=0x0 arg16=0x22000000 arg17=0x1016d6e8 arg18=0x0 arg19=0x44000000 arg20=0x0 arg21=0x10037c82208 arg22=0x1017b008 arg23=0x10143d18 arg24=0x10178854 arg25=0x10144f90 arg26=0x10037c821e8 arg27=0x0 arg28=0x0 arg29=0x0 arg30=0x0 arg31=0x809 arg32=0x3ffff788c010 arg33=0xc0000000000a7fe8 arg34=0x8000000000029033 arg35=0xc0000000000094c8 arg36=0xc0000000000094d0 arg37=0x0 arg38=0x42222844 arg39=0x1 arg40=0x700 arg41=0xc0000001fbe9bd50 arg42=0xc0000001fbe9bd30
Which is ugly as hell, but appears unchanged since before your patch.
I take it it's expected that the names are not decoded in the output?
Also I wonder why we choose "gpr" when "r" is the more usual prefix on powerpc.
I guess we can add new aliases to the table.
cheers
next prev parent reply other threads:[~2015-06-23 3:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 16:42 [PATCH 0/2] Consolidate redundant register/stack access code David Long
2015-06-15 16:42 ` [PATCH 1/2] Move the pt_regs_offset struct definition from arch to common include file David Long
2015-06-16 13:17 ` Rob Herring
2015-06-17 18:30 ` David Long
2015-06-30 3:29 ` Michael Ellerman
2015-07-22 4:46 ` David Long
2015-07-22 5:11 ` Michael Ellerman
2015-07-22 13:30 ` David Long
2015-06-19 4:19 ` Michael Ellerman
2015-06-19 14:12 ` David Long
2015-06-19 16:58 ` Kees Cook
2015-06-26 18:35 ` David Long
2015-06-23 3:32 ` Michael Ellerman [this message]
2015-06-23 13:48 ` David Long
2015-06-24 4:07 ` Michael Ellerman
2015-06-24 13:49 ` David Long
2015-06-15 16:42 ` [PATCH 2/2] Consolidate redundant register/stack access code David Long
2015-06-18 18:13 ` rkuo
2015-06-15 20:44 ` [PATCH 0/2] " Kees Cook
2015-06-15 20:58 ` David Long
2015-06-16 8:12 ` Martin Schwidefsky
2015-06-16 17:39 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435030328.28070.5.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=Nikolay.Borisov@arm$(echo .)com \
--cc=anton@samba$(echo .)org \
--cc=behanw@converseincode$(echo .)com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=dave.long@linaro$(echo .)org \
--cc=eparis@redhat$(echo .)com \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-hexagon@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux390@de$(echo .)ibm.com \
--cc=linux@arm$(echo .)linux.org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=luto@amacapital$(echo .)net \
--cc=mahesh@linux$(echo .)vnet.ibm.com \
--cc=mingo@redhat$(echo .)com \
--cc=oleg@redhat$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=rkuo@codeaurora$(echo .)org \
--cc=roland@hack$(echo .)frob.com \
--cc=rric@kernel$(echo .)org \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=tglx@linutronix$(echo .)de \
--cc=tj@kernel$(echo .)org \
--cc=will.deacon@arm$(echo .)com \
--cc=willeke@de$(echo .)ibm.com \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox