Subject: Re: [PATCH V9 05/13] powerpc, perf: Change name & type of 'pred' in power_pmu_bhrb_read

From: Daniel Axtens <[email-masked]>
Date: Thu, 25 Jun 2015 15:11:14 +1000

> 				cpuhw->bhrb_entries[u_index].to = addr;
> -				cpuhw->bhrb_entries[u_index].mispred = pred;
> -				cpuhw->bhrb_entries[u_index].predicted = ~pred;
> +				cpuhw->bhrb_entries[u_index].mispred = mispred;
> +				cpuhw->bhrb_entries[u_index].predicted =
> +								~mispred;
>  

This is much better! However, these are still bitwise rather than
logical inversions. They will work, but would it be easier to understand
if you used "!mispred"?

-- 
Regards,
Daniel