Subject: Re: [PATCH V9 02/13] powerpc, perf: Change type of the bhrb_users variable

From: Daniel Axtens <[email-masked]>
Date: Thu, 25 Jun 2015 15:42:00 +1000

> -	int				bhrb_users;
> +	unsigned int			bhrb_users;

OK, so this is a good start.

A quick git grep for bhrb_users reveals this:
perf/core-book3s.c:     WARN_ON_ONCE(cpuhw->bhrb_users < 0);

That occurs in power_pmu_bhrb_disable, immediately following a decrement
of bhrb_users. Now that the test can never be true, this patch should
change the function to check if bhrb_users is 0 before decrementing.

>  	void				*bhrb_context;
>  	struct	perf_branch_stack	bhrb_stack;
>  	struct	perf_branch_entry	bhrb_entries[BHRB_MAX_ENTRIES];

-- 
Regards,
Daniel