Subject: Re: [PATCH 1/1] cxl/vphb.c: Use phb pointer after NULL check

From: Michael Neuling <[email-masked]>
Date: Mon, 29 Jun 2015 20:43:37 +1000

On Mon, 2015-06-29 at 16:05 +0530, Maninder Singh wrote:
> static Anlaysis detected below error:-
> (error) Possible null pointer dereference: phb
>=20
> So, Use phb after NULL check.
>=20
> Signed-off-by: Maninder Singh <[email-masked]>

Thanks, looks good.

Acked-By: Michael Neuling <[email-masked]>

> ---
>  drivers/misc/cxl/vphb.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/misc/cxl/vphb.c b/drivers/misc/cxl/vphb.c
> index b1d1983a..2eba002 100644
> --- a/drivers/misc/cxl/vphb.c
> +++ b/drivers/misc/cxl/vphb.c
> @@ -112,9 +112,10 @@ static int cxl_pcie_config_info(struct pci_bus *bus,=
 unsigned int devfn,
>  	unsigned long addr;
> =20
>  	phb =3D pci_bus_to_host(bus);
> -	afu =3D (struct cxl_afu *)phb->private_data;
>  	if (phb =3D=3D NULL)
>  		return PCIBIOS_DEVICE_NOT_FOUND;
> +	afu =3D (struct cxl_afu *)phb->private_data;
> +
>  	if (cxl_pcie_cfg_record(bus->number, devfn) > afu->crs_num)
>  		return PCIBIOS_DEVICE_NOT_FOUND;
>  	if (offset >=3D (unsigned long)phb->cfg_data)