Subject: Re: [PATCH] cxl: Test the correct mmio space before unmapping

From: Michael Neuling <[email-masked]>
Date: Fri, 03 Jul 2015 10:23:16 +1000

On Thu, 2015-07-02 at 15:55 +1000, Daniel Axtens wrote:
> Before freeing p2n, test p2n, not p1n.
>=20
> Signed-off-by: Daniel Axtens <[email-masked]>

Nice catch but can you resend with a CC stable?

Mikey

>=20
> ---
>=20
> While a potentially nasty bug, this is only hit (at the moment)
> in cxl_remove, so it's probably not a candidate for stable.
> ---
>  drivers/misc/cxl/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
> index a16988d..fd43462 100644
> --- a/drivers/misc/cxl/pci.c
> +++ b/drivers/misc/cxl/pci.c
> @@ -540,7 +540,7 @@ err:
> =20
>  static void cxl_unmap_slice_regs(struct cxl_afu *afu)
>  {
> -	if (afu->p1n_mmio)
> +	if (afu->p2n_mmio)
>  		iounmap(afu->p2n_mmio);
>  	if (afu->p1n_mmio)
>  		iounmap(afu->p1n_mmio);