Subject: Re: [PATCH 1/2] powerpc/t1024rdb: add ina220 current sense node

From: Scott Wood <[email-masked]>
Date: Mon, 6 Jul 2015 16:48:19 -0500

On Fri, 2015-07-03 at 17:50 +0800, Shengzhou Liu wrote:
> Add support for INA220 current sense.
> 
> Signed-off-by: Shengzhou Liu <[email-masked]>
> ---
>  arch/powerpc/boot/dts/t1024rdb.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/powerpc/boot/dts/t1024rdb.dts 
> b/arch/powerpc/boot/dts/t1024rdb.dts
> index 733e723..43474d9 100644
> --- a/arch/powerpc/boot/dts/t1024rdb.dts
> +++ b/arch/powerpc/boot/dts/t1024rdb.dts
> @@ -114,6 +114,13 @@
>                               reg = <0x4c>;
>                       };
>  
> +                     /* INA220 Current Sense */

Do you mean "current sensor"?

Why is this comment needed here, but not in the t1023 file?

> +                      ina220@40{

Node names should be generic (which would also eliminate any reason for the 
above comment).

-Scott