From: Michael Ellerman <mpe@ellerman•id.au>
To: "Shreyas B. Prabhu" <shreyas@linux•vnet.ibm.com>
Cc: Paul Mackerras <paulus@samba•org>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH v2] powerpc/powernv: Fix race in updating core_idle_state
Date: Tue, 07 Jul 2015 10:22:38 +1000 [thread overview]
Message-ID: <1436228558.3341.1.camel@ellerman.id.au> (raw)
In-Reply-To: <1436213363-18419-1-git-send-email-shreyas@linux.vnet.ibm.com>
On Tue, 2015-07-07 at 01:39 +0530, Shreyas B. Prabhu wrote:
> core_idle_state is maintained for each core. It uses 0-7 bits to track
> whether a thread in the core has entered fastsleep or winkle. 8th bit is
> used as a lock bit.
...
> This patch fixes the above race by looping on the lock bit even while
> entering the idle states.
>
> Signed-off-by: Shreyas B. Prabhu <shreyas@linux•vnet.ibm.com>
> Fixes: 7b54e9f213f76 'powernv/powerpc: Add winkle support for offline
> cpus'
The sha is wrong, it should be 77b54e9f213f.
Also please don't wrap the description.
I recommend creating an alias or script that does:
$ git log --pretty=fixes -n 1 $commit | xclip
I've fixed it up, no need to resend.
cheers
next prev parent reply other threads:[~2015-07-07 0:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 20:09 [PATCH v2] powerpc/powernv: Fix race in updating core_idle_state Shreyas B. Prabhu
2015-07-07 0:22 ` Michael Ellerman [this message]
2015-07-07 1:17 ` Shreyas B Prabhu
2015-07-09 4:41 ` Daniel Axtens
2015-07-09 6:03 ` Shreyas B Prabhu
2015-07-09 7:07 ` Michael Ellerman
2015-07-07 10:38 ` [v2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436228558.3341.1.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
--cc=shreyas@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox