* [RESEND] powerpc/diu: adjust DIU initialization entry
@ 2015-07-07 7:51 Dongsheng Wang
2015-07-07 21:51 ` Scott Wood
0 siblings, 1 reply; 7+ messages in thread
From: Dongsheng Wang @ 2015-07-07 7:51 UTC (permalink / raw)
To: yorksun; +Cc: jason.jin, linuxppc-dev, Wang Dongsheng
From: Wang Dongsheng <dongsheng.wang@freescale•com>
Move fsl_diu_init into diu probe function, because it should be
initialized when system get diu device tree node, not always do
initialization.
Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale•com>
---
Changes:
Rebase original patch for upstream because fsl-diu-fb.c has moved to fbdev dir.
This patch is a long time ago, there is no feedback, and the Patchwork state
has been modified for the changes requested, I don't know why. So I resend
this patch to upstream.
diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c
index 7fa2e6f..164e22e 100644
--- a/drivers/video/fbdev/fsl-diu-fb.c
+++ b/drivers/video/fbdev/fsl-diu-fb.c
@@ -1680,6 +1680,105 @@ static ssize_t show_monitor(struct device *device,
return 0;
}
+#ifndef MODULE
+static int __init fsl_diu_setup(char *options)
+{
+ char *opt;
+ unsigned long val;
+
+ if (!options || !*options)
+ return 0;
+
+ while ((opt = strsep(&options, ",")) != NULL) {
+ if (!*opt)
+ continue;
+ if (!strncmp(opt, "monitor=", 8)) {
+ monitor_port = fsl_diu_name_to_port(opt + 8);
+ } else if (!strncmp(opt, "bpp=", 4)) {
+ if (!kstrtoul(opt + 4, 10, &val))
+ default_bpp = val;
+ } else {
+ fb_mode = opt;
+ }
+ }
+
+ return 0;
+}
+#endif
+
+static int fsl_diu_perpare(void)
+{
+#ifdef CONFIG_NOT_COHERENT_CACHE
+ struct device_node *np;
+ const u32 *prop;
+#endif
+#ifndef MODULE
+ char *option;
+
+ /*
+ * For kernel boot options (in 'video=xxxfb:<options>' format)
+ */
+ if (fb_get_options("fslfb", &option))
+ return -ENODEV;
+ fsl_diu_setup(option);
+#else
+ monitor_port = fsl_diu_name_to_port(monitor_string);
+#endif
+ pr_info("Freescale Display Interface Unit (DIU) framebuffer driver\n");
+
+ if (!diu_ops.set_pixel_clock) {
+ pr_info("%s: Board not support DIU. Can't dispaly video.\n",
+ __func__);
+ return -ENODEV;
+ }
+
+#ifdef CONFIG_NOT_COHERENT_CACHE
+ np = of_find_node_by_type(NULL, "cpu");
+ if (!np) {
+ pr_err("fsl-diu-fb: can't find 'cpu' device node\n");
+ return -ENODEV;
+ }
+
+ prop = of_get_property(np, "d-cache-size", NULL);
+ if (!prop) {
+ pr_err("fsl-diu-fb: missing 'd-cache-size'\n");
+ of_node_put(np);
+ return -ENODEV;
+ }
+
+ /*
+ * Freescale PLRU requires 13/8 times the cache size to do a proper
+ * displacement flush
+ */
+ coherence_data_size = be32_to_cpup(prop) * 13;
+ coherence_data_size /= 8;
+
+ pr_debug("fsl-diu-fb: coherence data size is %zu bytes\n",
+ coherence_data_size);
+
+ prop = of_get_property(np, "d-cache-line-size", NULL);
+ if (!prop) {
+ pr_err("fsl-diu-fb: missing 'd-cache-line-size'\n");
+ of_node_put(np);
+ return -ENODEV;
+ }
+ d_cache_line_size = be32_to_cpup(prop);
+
+ pr_debug("fsl-diu-fb: cache lines size is %u bytes\n",
+ d_cache_line_size);
+
+ of_node_put(np);
+ coherence_data = vmalloc(coherence_data_size);
+ if (!coherence_data) {
+ pr_err("fsl-diu-fb: could not allocate coherence data\n");
+ pr_err("coherence_data_size=%zu)\n", coherence_data_size);
+ return -ENOMEM;
+ }
+
+#endif
+ return 0;
+}
+
static int fsl_diu_probe(struct platform_device *pdev)
{
struct device_node *np = pdev->dev.of_node;
@@ -1690,10 +1789,16 @@ static int fsl_diu_probe(struct platform_device *pdev)
unsigned int i;
int ret;
+ ret = fsl_diu_perpare();
+ if (ret)
+ goto out_perpare;
+
data = dmam_alloc_coherent(&pdev->dev, sizeof(struct fsl_diu_data),
&dma_addr, GFP_DMA | __GFP_ZERO);
- if (!data)
- return -ENOMEM;
+ if (!data) {
+ ret = -ENOMEM;
+ goto out_perpare;
+ }
data->dma_addr = dma_addr;
/*
@@ -1819,6 +1924,11 @@ error:
iounmap(data->diu_reg);
+out_perpare:
+#if defined(CONFIG_NOT_COHERENT_CACHE)
+ if (coherence_data)
+ vfree(coherence_data);
+#endif
return ret;
}
@@ -1837,34 +1947,12 @@ static int fsl_diu_remove(struct platform_device *pdev)
iounmap(data->diu_reg);
+#if defined(CONFIG_NOT_COHERENT_CACHE)
+ vfree(coherence_data);
+#endif
return 0;
}
-#ifndef MODULE
-static int __init fsl_diu_setup(char *options)
-{
- char *opt;
- unsigned long val;
-
- if (!options || !*options)
- return 0;
-
- while ((opt = strsep(&options, ",")) != NULL) {
- if (!*opt)
- continue;
- if (!strncmp(opt, "monitor=", 8)) {
- monitor_port = fsl_diu_name_to_port(opt + 8);
- } else if (!strncmp(opt, "bpp=", 4)) {
- if (!kstrtoul(opt + 4, 10, &val))
- default_bpp = val;
- } else
- fb_mode = opt;
- }
-
- return 0;
-}
-#endif
-
static struct of_device_id fsl_diu_match[] = {
#ifdef CONFIG_PPC_MPC512x
{
@@ -1891,88 +1979,12 @@ static struct platform_driver fsl_diu_driver = {
static int __init fsl_diu_init(void)
{
-#ifdef CONFIG_NOT_COHERENT_CACHE
- struct device_node *np;
- const u32 *prop;
-#endif
- int ret;
-#ifndef MODULE
- char *option;
-
- /*
- * For kernel boot options (in 'video=xxxfb:<options>' format)
- */
- if (fb_get_options("fslfb", &option))
- return -ENODEV;
- fsl_diu_setup(option);
-#else
- monitor_port = fsl_diu_name_to_port(monitor_string);
-#endif
- pr_info("Freescale Display Interface Unit (DIU) framebuffer driver\n");
-
-#ifdef CONFIG_NOT_COHERENT_CACHE
- np = of_find_node_by_type(NULL, "cpu");
- if (!np) {
- pr_err("fsl-diu-fb: can't find 'cpu' device node\n");
- return -ENODEV;
- }
-
- prop = of_get_property(np, "d-cache-size", NULL);
- if (prop == NULL) {
- pr_err("fsl-diu-fb: missing 'd-cache-size' property' "
- "in 'cpu' node\n");
- of_node_put(np);
- return -ENODEV;
- }
-
- /*
- * Freescale PLRU requires 13/8 times the cache size to do a proper
- * displacement flush
- */
- coherence_data_size = be32_to_cpup(prop) * 13;
- coherence_data_size /= 8;
-
- pr_debug("fsl-diu-fb: coherence data size is %zu bytes\n",
- coherence_data_size);
-
- prop = of_get_property(np, "d-cache-line-size", NULL);
- if (prop == NULL) {
- pr_err("fsl-diu-fb: missing 'd-cache-line-size' property' "
- "in 'cpu' node\n");
- of_node_put(np);
- return -ENODEV;
- }
- d_cache_line_size = be32_to_cpup(prop);
-
- pr_debug("fsl-diu-fb: cache lines size is %u bytes\n",
- d_cache_line_size);
-
- of_node_put(np);
- coherence_data = vmalloc(coherence_data_size);
- if (!coherence_data) {
- pr_err("fsl-diu-fb: could not allocate coherence data "
- "(size=%zu)\n", coherence_data_size);
- return -ENOMEM;
- }
-
-#endif
-
- ret = platform_driver_register(&fsl_diu_driver);
- if (ret) {
- pr_err("fsl-diu-fb: failed to register platform driver\n");
-#if defined(CONFIG_NOT_COHERENT_CACHE)
- vfree(coherence_data);
-#endif
- }
- return ret;
+ return platform_driver_register(&fsl_diu_driver);
}
static void __exit fsl_diu_exit(void)
{
platform_driver_unregister(&fsl_diu_driver);
-#if defined(CONFIG_NOT_COHERENT_CACHE)
- vfree(coherence_data);
-#endif
}
module_init(fsl_diu_init);
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [RESEND] powerpc/diu: adjust DIU initialization entry
2015-07-07 7:51 [RESEND] powerpc/diu: adjust DIU initialization entry Dongsheng Wang
@ 2015-07-07 21:51 ` Scott Wood
2015-07-08 2:30 ` Wang Dongsheng
0 siblings, 1 reply; 7+ messages in thread
From: Scott Wood @ 2015-07-07 21:51 UTC (permalink / raw)
To: Dongsheng Wang; +Cc: yorksun, linuxppc-dev, jason.jin
On Tue, 2015-07-07 at 15:51 +0800, Dongsheng Wang wrote:
> From: Wang Dongsheng <dongsheng.wang@freescale•com>
>
> Move fsl_diu_init into diu probe function, because it should be
> initialized when system get diu device tree node, not always do
> initialization.
>
> Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale•com>
> ---
> Changes:
> Rebase original patch for upstream because fsl-diu-fb.c has moved to fbdev
> dir.
>
> This patch is a long time ago, there is no feedback, and the Patchwork state
> has been modified for the changes requested, I don't know why. So I resend
> this patch to upstream.
Please send this to the proper list and maintainer, and with a subject prefix
that indicates it's an fbdev patch.
-Scott
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [RESEND] powerpc/diu: adjust DIU initialization entry
2015-07-07 21:51 ` Scott Wood
@ 2015-07-08 2:30 ` Wang Dongsheng
2015-07-08 2:41 ` Scott Wood
0 siblings, 1 reply; 7+ messages in thread
From: Wang Dongsheng @ 2015-07-08 2:30 UTC (permalink / raw)
To: Scott Wood; +Cc: York Sun, linuxppc-dev@lists•ozlabs.org, Jin Jason
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogV2VkbmVzZGF5LCBKdWx5IDA4LCAyMDE1IDU6NTEgQU0NCj4gVG86IFdhbmcg
RG9uZ3NoZW5nLUI0MDUzNA0KPiBDYzogU3VuIFlvcmstUjU4NDk1OyBsaW51eHBwYy1kZXZAbGlz
dHMub3psYWJzLm9yZzsgSmluIFpoZW5neGlvbmctUjY0MTg4DQo+IFN1YmplY3Q6IFJlOiBbUkVT
RU5EXSBwb3dlcnBjL2RpdTogYWRqdXN0IERJVSBpbml0aWFsaXphdGlvbiBlbnRyeQ0KPiANCj4g
T24gVHVlLCAyMDE1LTA3LTA3IGF0IDE1OjUxICswODAwLCBEb25nc2hlbmcgV2FuZyB3cm90ZToN
Cj4gPiBGcm9tOiBXYW5nIERvbmdzaGVuZyA8ZG9uZ3NoZW5nLndhbmdAZnJlZXNjYWxlLmNvbT4N
Cj4gPg0KPiA+IE1vdmUgZnNsX2RpdV9pbml0IGludG8gZGl1IHByb2JlIGZ1bmN0aW9uLCBiZWNh
dXNlIGl0IHNob3VsZCBiZQ0KPiA+IGluaXRpYWxpemVkIHdoZW4gc3lzdGVtIGdldCBkaXUgZGV2
aWNlIHRyZWUgbm9kZSwgbm90IGFsd2F5cyBkbw0KPiA+IGluaXRpYWxpemF0aW9uLg0KPiA+DQo+
ID4gU2lnbmVkLW9mZi1ieTogV2FuZyBEb25nc2hlbmcgPGRvbmdzaGVuZy53YW5nQGZyZWVzY2Fs
ZS5jb20+DQo+ID4gLS0tDQo+ID4gQ2hhbmdlczoNCj4gPiBSZWJhc2Ugb3JpZ2luYWwgcGF0Y2gg
Zm9yIHVwc3RyZWFtIGJlY2F1c2UgZnNsLWRpdS1mYi5jIGhhcyBtb3ZlZCB0bw0KPiA+IGZiZGV2
IGRpci4NCj4gPg0KPiA+IFRoaXMgcGF0Y2ggaXMgYSBsb25nIHRpbWUgYWdvLCB0aGVyZSBpcyBu
byBmZWVkYmFjaywgYW5kIHRoZSBQYXRjaHdvcmsNCj4gPiBzdGF0ZSBoYXMgYmVlbiBtb2RpZmll
ZCBmb3IgdGhlIGNoYW5nZXMgcmVxdWVzdGVkLCBJIGRvbid0IGtub3cgd2h5Lg0KPiA+IFNvIEkg
cmVzZW5kIHRoaXMgcGF0Y2ggdG8gdXBzdHJlYW0uDQo+IA0KPiBQbGVhc2Ugc2VuZCB0aGlzIHRv
IHRoZSBwcm9wZXIgbGlzdCBhbmQgbWFpbnRhaW5lciwgYW5kIHdpdGggYSBzdWJqZWN0IHByZWZp
eA0KPiB0aGF0IGluZGljYXRlcyBpdCdzIGFuIGZiZGV2IHBhdGNoLg0KPiANClRoYW5rcy4NCg0K
SSB3aWxsIHNlbmQgdGhpcyBwYXRjaCB0byBsaW51eC1mYmRldkB2Z2VyLmtlcm5lbC5vcmcuDQoN
ClBsZWFzZSBpZ25vcmUgdGhpcyBwYXRjaC4NCg0KUmVnYXJkcywNCi1Eb25nc2hlbmcNCg==
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND] powerpc/diu: adjust DIU initialization entry
2015-07-08 2:30 ` Wang Dongsheng
@ 2015-07-08 2:41 ` Scott Wood
2015-07-08 2:46 ` Wang Dongsheng
0 siblings, 1 reply; 7+ messages in thread
From: Scott Wood @ 2015-07-08 2:41 UTC (permalink / raw)
To: Wang Dongsheng-B40534
Cc: Sun York-R58495, linuxppc-dev@lists•ozlabs.org,
Jin Zhengxiong-R64188
On Tue, 2015-07-07 at 21:30 -0500, Wang Dongsheng-B40534 wrote:
>
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Wednesday, July 08, 2015 5:51 AM
> > To: Wang Dongsheng-B40534
> > Cc: Sun York-R58495; linuxppc-dev@lists•ozlabs.org; Jin Zhengxiong-R64188
> > Subject: Re: [RESEND] powerpc/diu: adjust DIU initialization entry
> >
> > On Tue, 2015-07-07 at 15:51 +0800, Dongsheng Wang wrote:
> > > From: Wang Dongsheng <dongsheng.wang@freescale•com>
> > >
> > > Move fsl_diu_init into diu probe function, because it should be
> > > initialized when system get diu device tree node, not always do
> > > initialization.
> > >
> > > Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale•com>
> > > ---
> > > Changes:
> > > Rebase original patch for upstream because fsl-diu-fb.c has moved to
> > > fbdev dir.
> > >
> > > This patch is a long time ago, there is no feedback, and the Patchwork
> > > state has been modified for the changes requested, I don't know why.
> > > So I resend this patch to upstream.
> >
> > Please send this to the proper list and maintainer, and with a subject
> > prefix
> > that indicates it's an fbdev patch.
> >
> Thanks.
>
> I will send this patch to linux-fbdev@vger•kernel.org.
>
> Please ignore this patch.
You still didn't fix the subject line...
-Scott
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [RESEND] powerpc/diu: adjust DIU initialization entry
2015-07-08 2:41 ` Scott Wood
@ 2015-07-08 2:46 ` Wang Dongsheng
2015-07-08 2:48 ` Scott Wood
0 siblings, 1 reply; 7+ messages in thread
From: Wang Dongsheng @ 2015-07-08 2:46 UTC (permalink / raw)
To: Scott Wood; +Cc: York Sun, linuxppc-dev@lists•ozlabs.org, Jin Jason
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogV2VkbmVzZGF5LCBKdWx5IDA4LCAyMDE1IDEwOjQxIEFNDQo+IFRvOiBXYW5n
IERvbmdzaGVuZy1CNDA1MzQNCj4gQ2M6IFN1biBZb3JrLVI1ODQ5NTsgbGludXhwcGMtZGV2QGxp
c3RzLm96bGFicy5vcmc7IEppbiBaaGVuZ3hpb25nLVI2NDE4OA0KPiBTdWJqZWN0OiBSZTogW1JF
U0VORF0gcG93ZXJwYy9kaXU6IGFkanVzdCBESVUgaW5pdGlhbGl6YXRpb24gZW50cnkNCj4gDQo+
IE9uIFR1ZSwgMjAxNS0wNy0wNyBhdCAyMTozMCAtMDUwMCwgV2FuZyBEb25nc2hlbmctQjQwNTM0
IHdyb3RlOg0KPiA+DQo+ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gRnJv
bTogV29vZCBTY290dC1CMDc0MjENCj4gPiA+IFNlbnQ6IFdlZG5lc2RheSwgSnVseSAwOCwgMjAx
NSA1OjUxIEFNDQo+ID4gPiBUbzogV2FuZyBEb25nc2hlbmctQjQwNTM0DQo+ID4gPiBDYzogU3Vu
IFlvcmstUjU4NDk1OyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZzsgSmluDQo+ID4gPiBa
aGVuZ3hpb25nLVI2NDE4OA0KPiA+ID4gU3ViamVjdDogUmU6IFtSRVNFTkRdIHBvd2VycGMvZGl1
OiBhZGp1c3QgRElVIGluaXRpYWxpemF0aW9uIGVudHJ5DQo+ID4gPg0KPiA+ID4gT24gVHVlLCAy
MDE1LTA3LTA3IGF0IDE1OjUxICswODAwLCBEb25nc2hlbmcgV2FuZyB3cm90ZToNCj4gPiA+ID4g
RnJvbTogV2FuZyBEb25nc2hlbmcgPGRvbmdzaGVuZy53YW5nQGZyZWVzY2FsZS5jb20+DQo+ID4g
PiA+DQo+ID4gPiA+IE1vdmUgZnNsX2RpdV9pbml0IGludG8gZGl1IHByb2JlIGZ1bmN0aW9uLCBi
ZWNhdXNlIGl0IHNob3VsZCBiZQ0KPiA+ID4gPiBpbml0aWFsaXplZCB3aGVuIHN5c3RlbSBnZXQg
ZGl1IGRldmljZSB0cmVlIG5vZGUsIG5vdCBhbHdheXMgZG8NCj4gPiA+ID4gaW5pdGlhbGl6YXRp
b24uDQo+ID4gPiA+DQo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IFdhbmcgRG9uZ3NoZW5nIDxkb25n
c2hlbmcud2FuZ0BmcmVlc2NhbGUuY29tPg0KPiA+ID4gPiAtLS0NCj4gPiA+ID4gQ2hhbmdlczoN
Cj4gPiA+ID4gUmViYXNlIG9yaWdpbmFsIHBhdGNoIGZvciB1cHN0cmVhbSBiZWNhdXNlIGZzbC1k
aXUtZmIuYyBoYXMgbW92ZWQNCj4gPiA+ID4gdG8gZmJkZXYgZGlyLg0KPiA+ID4gPg0KPiA+ID4g
PiBUaGlzIHBhdGNoIGlzIGEgbG9uZyB0aW1lIGFnbywgdGhlcmUgaXMgbm8gZmVlZGJhY2ssIGFu
ZCB0aGUNCj4gPiA+ID4gUGF0Y2h3b3JrIHN0YXRlIGhhcyBiZWVuIG1vZGlmaWVkIGZvciB0aGUg
Y2hhbmdlcyByZXF1ZXN0ZWQsIEkgZG9uJ3Qga25vdw0KPiB3aHkuDQo+ID4gPiA+IFNvIEkgcmVz
ZW5kIHRoaXMgcGF0Y2ggdG8gdXBzdHJlYW0uDQo+ID4gPg0KPiA+ID4gUGxlYXNlIHNlbmQgdGhp
cyB0byB0aGUgcHJvcGVyIGxpc3QgYW5kIG1haW50YWluZXIsIGFuZCB3aXRoIGENCj4gPiA+IHN1
YmplY3QgcHJlZml4IHRoYXQgaW5kaWNhdGVzIGl0J3MgYW4gZmJkZXYgcGF0Y2guDQo+ID4gPg0K
PiA+IFRoYW5rcy4NCj4gPg0KPiA+IEkgd2lsbCBzZW5kIHRoaXMgcGF0Y2ggdG8gbGludXgtZmJk
ZXZAdmdlci5rZXJuZWwub3JnLg0KPiA+DQo+ID4gUGxlYXNlIGlnbm9yZSB0aGlzIHBhdGNoLg0K
PiANCj4gWW91IHN0aWxsIGRpZG4ndCBmaXggdGhlIHN1YmplY3QgbGluZS4uLg0KPiANCg0KVGhl
IERJVSBiZWxvbmdzIHRvIHRoZSBQT1dFUlBDLCBuZWVkIEkgZml4IHRoaXM/IGZiZGV2L2RpdT8N
Cg0KUmVnYXJkcywNCi1Eb25nc2hlbmcNCg0K
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND] powerpc/diu: adjust DIU initialization entry
2015-07-08 2:46 ` Wang Dongsheng
@ 2015-07-08 2:48 ` Scott Wood
2015-07-08 2:51 ` Wang Dongsheng
0 siblings, 1 reply; 7+ messages in thread
From: Scott Wood @ 2015-07-08 2:48 UTC (permalink / raw)
To: Wang Dongsheng-B40534
Cc: Sun York-R58495, linuxppc-dev@lists•ozlabs.org,
Jin Zhengxiong-R64188
On Tue, 2015-07-07 at 21:46 -0500, Wang Dongsheng-B40534 wrote:
>
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Wednesday, July 08, 2015 10:41 AM
> > To: Wang Dongsheng-B40534
> > Cc: Sun York-R58495; linuxppc-dev@lists•ozlabs.org; Jin Zhengxiong-R64188
> > Subject: Re: [RESEND] powerpc/diu: adjust DIU initialization entry
> >
> > On Tue, 2015-07-07 at 21:30 -0500, Wang Dongsheng-B40534 wrote:
> > >
> > > > -----Original Message-----
> > > > From: Wood Scott-B07421
> > > > Sent: Wednesday, July 08, 2015 5:51 AM
> > > > To: Wang Dongsheng-B40534
> > > > Cc: Sun York-R58495; linuxppc-dev@lists•ozlabs.org; Jin
> > > > Zhengxiong-R64188
> > > > Subject: Re: [RESEND] powerpc/diu: adjust DIU initialization entry
> > > >
> > > > On Tue, 2015-07-07 at 15:51 +0800, Dongsheng Wang wrote:
> > > > > From: Wang Dongsheng <dongsheng.wang@freescale•com>
> > > > >
> > > > > Move fsl_diu_init into diu probe function, because it should be
> > > > > initialized when system get diu device tree node, not always do
> > > > > initialization.
> > > > >
> > > > > Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale•com>
> > > > > ---
> > > > > Changes:
> > > > > Rebase original patch for upstream because fsl-diu-fb.c has moved
> > > > > to fbdev dir.
> > > > >
> > > > > This patch is a long time ago, there is no feedback, and the
> > > > > Patchwork state has been modified for the changes requested, I
> > > > > don't know
> > why.
> > > > > So I resend this patch to upstream.
> > > >
> > > > Please send this to the proper list and maintainer, and with a
> > > > subject prefix that indicates it's an fbdev patch.
> > > >
> > > Thanks.
> > >
> > > I will send this patch to linux-fbdev@vger•kernel.org.
> > >
> > > Please ignore this patch.
> >
> > You still didn't fix the subject line...
> >
>
> The DIU belongs to the POWERPC,
No, it doesn't belong to arch/powerpc, it belongs to drivers/video/fbdev.
> need I fix this? fbdev/diu?
"video: fbdev: fsl-diu:" seems to be the style that subtree uses.
-Scott
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [RESEND] powerpc/diu: adjust DIU initialization entry
2015-07-08 2:48 ` Scott Wood
@ 2015-07-08 2:51 ` Wang Dongsheng
0 siblings, 0 replies; 7+ messages in thread
From: Wang Dongsheng @ 2015-07-08 2:51 UTC (permalink / raw)
To: Scott Wood; +Cc: York Sun, linuxppc-dev@lists•ozlabs.org, Jin Jason
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogV2VkbmVzZGF5LCBKdWx5IDA4LCAyMDE1IDEwOjQ4IEFNDQo+IFRvOiBXYW5n
IERvbmdzaGVuZy1CNDA1MzQNCj4gQ2M6IFN1biBZb3JrLVI1ODQ5NTsgbGludXhwcGMtZGV2QGxp
c3RzLm96bGFicy5vcmc7IEppbiBaaGVuZ3hpb25nLVI2NDE4OA0KPiBTdWJqZWN0OiBSZTogW1JF
U0VORF0gcG93ZXJwYy9kaXU6IGFkanVzdCBESVUgaW5pdGlhbGl6YXRpb24gZW50cnkNCj4gDQo+
IE9uIFR1ZSwgMjAxNS0wNy0wNyBhdCAyMTo0NiAtMDUwMCwgV2FuZyBEb25nc2hlbmctQjQwNTM0
IHdyb3RlOg0KPiA+DQo+ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gRnJv
bTogV29vZCBTY290dC1CMDc0MjENCj4gPiA+IFNlbnQ6IFdlZG5lc2RheSwgSnVseSAwOCwgMjAx
NSAxMDo0MSBBTQ0KPiA+ID4gVG86IFdhbmcgRG9uZ3NoZW5nLUI0MDUzNA0KPiA+ID4gQ2M6IFN1
biBZb3JrLVI1ODQ5NTsgbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IEppbg0KPiA+ID4g
Wmhlbmd4aW9uZy1SNjQxODgNCj4gPiA+IFN1YmplY3Q6IFJlOiBbUkVTRU5EXSBwb3dlcnBjL2Rp
dTogYWRqdXN0IERJVSBpbml0aWFsaXphdGlvbiBlbnRyeQ0KPiA+ID4NCj4gPiA+IE9uIFR1ZSwg
MjAxNS0wNy0wNyBhdCAyMTozMCAtMDUwMCwgV2FuZyBEb25nc2hlbmctQjQwNTM0IHdyb3RlOg0K
PiA+ID4gPg0KPiA+ID4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gPiA+ID4g
RnJvbTogV29vZCBTY290dC1CMDc0MjENCj4gPiA+ID4gPiBTZW50OiBXZWRuZXNkYXksIEp1bHkg
MDgsIDIwMTUgNTo1MSBBTQ0KPiA+ID4gPiA+IFRvOiBXYW5nIERvbmdzaGVuZy1CNDA1MzQNCj4g
PiA+ID4gPiBDYzogU3VuIFlvcmstUjU4NDk1OyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9y
ZzsgSmluDQo+ID4gPiA+ID4gWmhlbmd4aW9uZy1SNjQxODgNCj4gPiA+ID4gPiBTdWJqZWN0OiBS
ZTogW1JFU0VORF0gcG93ZXJwYy9kaXU6IGFkanVzdCBESVUgaW5pdGlhbGl6YXRpb24NCj4gPiA+
ID4gPiBlbnRyeQ0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gT24gVHVlLCAyMDE1LTA3LTA3IGF0IDE1
OjUxICswODAwLCBEb25nc2hlbmcgV2FuZyB3cm90ZToNCj4gPiA+ID4gPiA+IEZyb206IFdhbmcg
RG9uZ3NoZW5nIDxkb25nc2hlbmcud2FuZ0BmcmVlc2NhbGUuY29tPg0KPiA+ID4gPiA+ID4NCj4g
PiA+ID4gPiA+IE1vdmUgZnNsX2RpdV9pbml0IGludG8gZGl1IHByb2JlIGZ1bmN0aW9uLCBiZWNh
dXNlIGl0IHNob3VsZA0KPiA+ID4gPiA+ID4gYmUgaW5pdGlhbGl6ZWQgd2hlbiBzeXN0ZW0gZ2V0
IGRpdSBkZXZpY2UgdHJlZSBub2RlLCBub3QNCj4gPiA+ID4gPiA+IGFsd2F5cyBkbyBpbml0aWFs
aXphdGlvbi4NCj4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBXYW5nIERv
bmdzaGVuZyA8ZG9uZ3NoZW5nLndhbmdAZnJlZXNjYWxlLmNvbT4NCj4gPiA+ID4gPiA+IC0tLQ0K
PiA+ID4gPiA+ID4gQ2hhbmdlczoNCj4gPiA+ID4gPiA+IFJlYmFzZSBvcmlnaW5hbCBwYXRjaCBm
b3IgdXBzdHJlYW0gYmVjYXVzZSBmc2wtZGl1LWZiLmMgaGFzDQo+ID4gPiA+ID4gPiBtb3ZlZCB0
byBmYmRldiBkaXIuDQo+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gVGhpcyBwYXRjaCBpcyBhIGxv
bmcgdGltZSBhZ28sIHRoZXJlIGlzIG5vIGZlZWRiYWNrLCBhbmQgdGhlDQo+ID4gPiA+ID4gPiBQ
YXRjaHdvcmsgc3RhdGUgaGFzIGJlZW4gbW9kaWZpZWQgZm9yIHRoZSBjaGFuZ2VzIHJlcXVlc3Rl
ZCwgSQ0KPiA+ID4gPiA+ID4gZG9uJ3Qga25vdw0KPiA+ID4gd2h5Lg0KPiA+ID4gPiA+ID4gU28g
SSByZXNlbmQgdGhpcyBwYXRjaCB0byB1cHN0cmVhbS4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+IFBs
ZWFzZSBzZW5kIHRoaXMgdG8gdGhlIHByb3BlciBsaXN0IGFuZCBtYWludGFpbmVyLCBhbmQgd2l0
aCBhDQo+ID4gPiA+ID4gc3ViamVjdCBwcmVmaXggdGhhdCBpbmRpY2F0ZXMgaXQncyBhbiBmYmRl
diBwYXRjaC4NCj4gPiA+ID4gPg0KPiA+ID4gPiBUaGFua3MuDQo+ID4gPiA+DQo+ID4gPiA+IEkg
d2lsbCBzZW5kIHRoaXMgcGF0Y2ggdG8gbGludXgtZmJkZXZAdmdlci5rZXJuZWwub3JnLg0KPiA+
ID4gPg0KPiA+ID4gPiBQbGVhc2UgaWdub3JlIHRoaXMgcGF0Y2guDQo+ID4gPg0KPiA+ID4gWW91
IHN0aWxsIGRpZG4ndCBmaXggdGhlIHN1YmplY3QgbGluZS4uLg0KPiA+ID4NCj4gPg0KPiA+IFRo
ZSBESVUgYmVsb25ncyB0byB0aGUgUE9XRVJQQywNCj4gDQo+IE5vLCBpdCBkb2Vzbid0IGJlbG9u
ZyB0byBhcmNoL3Bvd2VycGMsIGl0IGJlbG9uZ3MgdG8gZHJpdmVycy92aWRlby9mYmRldi4NCj4g
DQo+ID4gIG5lZWQgSSBmaXggdGhpcz8gZmJkZXYvZGl1Pw0KPiANCj4gInZpZGVvOiBmYmRldjog
ZnNsLWRpdToiIHNlZW1zIHRvIGJlIHRoZSBzdHlsZSB0aGF0IHN1YnRyZWUgdXNlcy4NCg0KRml4
IGl0IGluIG5leHQgdmVyc2lvbi4gUGxlYXNlIGNvbW1lbnQgaW4gbXkgbmV3IHBhdGNoLCBJIHdp
bGwgZml4IGl0Lg0KDQpSZWdhcmRzLA0KLURvbmdzaGVuZw0K
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-07-08 2:51 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-07 7:51 [RESEND] powerpc/diu: adjust DIU initialization entry Dongsheng Wang
2015-07-07 21:51 ` Scott Wood
2015-07-08 2:30 ` Wang Dongsheng
2015-07-08 2:41 ` Scott Wood
2015-07-08 2:46 ` Wang Dongsheng
2015-07-08 2:48 ` Scott Wood
2015-07-08 2:51 ` Wang Dongsheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox