From: Paul Bolle <pebolle@tiscali•nl>
To: Roy Pledge <Roy.Pledge@freescale•com>
Cc: linuxppc-dev@lists•ozlabs.org, scottwood@freescale•com,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH 04/11] soc/fsl: Introduce drivers for the DPAA QMan
Date: Sat, 11 Jul 2015 12:34:08 +0200 [thread overview]
Message-ID: <1436610848.20619.258.camel@tiscali.nl> (raw)
In-Reply-To: <1436473322-21247-5-git-send-email-Roy.Pledge@freescale.com>
On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote:
> --- a/drivers/soc/fsl/qbman/Kconfig
> +++ b/drivers/soc/fsl/qbman/Kconfig
> +config FSL_QMAN
> + tristate "QMan device management"
> + default n
> + help
> + FSL DPAA QMan driver
> +config FSL_QMAN_POLL_LIMIT
> + int
> + default 32
This Kconfig symbol will always be set to its default (32). So why
bother with a Kconfig symbol. Can't you use, say, a preprocessor define
directly?
> +config FSL_QMAN_CONFIG
> + bool "QMan device management"
> + default y
> + help
> + If this linux image is running natively, you need this option. If this
> + linux image is running as a guest OS under the hypervisor, only one
> + guest OS ("the control plane") needs this option.
> +config FSL_QMAN_CI_SCHED_CFG_SRCCIV
> + int
> + depends on FSL_QMAN_CONFIG
> + default 4
> +
> +config FSL_QMAN_CI_SCHED_CFG_SRQ_W
> + int
> + depends on FSL_QMAN_CONFIG
> + default 3
> +
> +config FSL_QMAN_CI_SCHED_CFG_RW_W
> + int
> + depends on FSL_QMAN_CONFIG
> + default 2
> +
> +config FSL_QMAN_CI_SCHED_CFG_BMAN_W
> + int
> + depends on FSL_QMAN_CONFIG
> + default 2
Ditto.
> +config FSL_QMAN_PIRQ_DQRR_ITHRESH
> + int
> + default 12
> +
> +config FSL_QMAN_PIRQ_MR_ITHRESH
> + int
> + default 4
> +
> +config FSL_QMAN_PIRQ_IPERIOD
> + int
> + default 100
Ditto.
> --- a/drivers/soc/fsl/qbman/Makefile
> +++ b/drivers/soc/fsl/qbman/Makefile
> +obj-$(CONFIG_FSL_QMAN) += qman_api.o qman_utils.o qman_driver.o
If FSL_QMAN is set to 'm' this should generate three modules. Is three
modules what you want? (Just to be safe: cross compiling ran into
problems, even for PPC64, probably because of silliness on my side. So I
couldn't check this. And I trust make's results more than I trust my
ability to parse Makefiles.)
Besides, there's no MODULE_LICENSE() in any of their source files. So,
whether you create one or three modules, loading a module will trigger a
warning and taint the kernel.
> +obj-$(CONFIG_FSL_QMAN_CONFIG) += qman.o qman_portal.o
> --- /dev/null
> +++ b/drivers/soc/fsl/qbman/qman.c
> +MODULE_DEVICE_TABLE(of, of_fsl_qman_ids);
qman.o is built if FSL_QMAN_CONFIG is set. FSL_QMAN_CONFIG is a bool
symbol. The net effect is that MODULE_DEVICE_TABLE is preprocessed away.
> +static struct platform_driver of_fsl_qman_driver = {
> + .driver = {
> + .name = DRV_NAME,
> + .of_match_table = of_fsl_qman_ids,
> + },
> + .probe = of_fsl_qman_probe,
> + .remove = of_fsl_qman_remove,
> +};
> +
> +module_platform_driver(of_fsl_qman_driver);
As of v4.2-rc1 you can use builtin_platform_driver() for built-in only
code.
Thanks,
Paul Bolle
next prev parent reply other threads:[~2015-07-11 10:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 20:21 [PATCH 00/11] Freescale DPAA QBMan Drivers Roy Pledge
2015-07-09 20:21 ` [PATCH 01/11] powerpc: re-add devm_ioremap_prot() Roy Pledge
2015-07-09 20:21 ` [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver Roy Pledge
2015-07-10 8:38 ` Paul Bolle
2015-07-10 17:31 ` Scott Wood
2015-07-10 18:29 ` Roy Pledge
2015-07-10 18:50 ` Scott Wood
2015-07-22 16:15 ` Horia Geantă
2015-07-10 11:36 ` Paul Bolle
2015-07-10 17:33 ` Scott Wood
2015-07-10 20:57 ` Roy Pledge
2015-07-10 21:12 ` Scott Wood
2015-07-09 20:21 ` [PATCH 03/11] soc/fsl: Introduce the DPAA BMan portal driver Roy Pledge
2015-07-10 13:32 ` Paul Bolle
2015-07-10 15:19 ` Roy Pledge
2015-07-10 16:47 ` Paul Bolle
2015-07-09 20:21 ` [PATCH 04/11] soc/fsl: Introduce drivers for the DPAA QMan Roy Pledge
2015-07-11 10:34 ` Paul Bolle [this message]
2015-07-09 20:21 ` [PATCH 05/11] soc/bman: Add self-tester for BMan driver Roy Pledge
2015-07-09 20:21 ` [PATCH 06/11] soc/qman: Add self-tester for QMan driver Roy Pledge
2015-07-09 20:21 ` [PATCH 07/11] soc/bman: Add debugfs support for the BMan driver Roy Pledge
2015-07-09 20:21 ` [PATCH 08/11] soc/qman: Add debugfs support for the QMan driver Roy Pledge
2015-07-09 20:22 ` [PATCH 09/11] soc/bman: Add HOTPLUG_CPU support to the BMan driver Roy Pledge
2015-07-09 20:22 ` [PATCH 10/11] soc/qman: Add HOTPLUG_CPU support to the QMan driver Roy Pledge
2015-07-09 20:22 ` [PATCH 11/11] soc/qman: add qman_delete_cgr_safe() Roy Pledge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436610848.20619.258.camel@tiscali.nl \
--to=pebolle@tiscali$(echo .)nl \
--cc=Roy.Pledge@freescale$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox