From: Michael Ellerman <mpe@ellerman•id.au>
To: Nishanth Aravamudan <nacc@linux•vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead•org>,
linux-kernel@vger•kernel.org, Paul Mackerras <paulus@samba•org>,
Anton Blanchard <anton@samba•org>,
David Rientjes <rientjes@google•com>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [RFC,1/2] powerpc/numa: fix cpu_to_node() usage during boot
Date: Wed, 15 Jul 2015 10:22:23 +1000 [thread overview]
Message-ID: <1436919743.10956.2.camel@ellerman.id.au> (raw)
In-Reply-To: <20150708231623.GB44862@linux.vnet.ibm.com>
On Wed, 2015-07-08 at 16:16 -0700, Nishanth Aravamudan wrote:
> On 08.07.2015 [14:00:56 +1000], Michael Ellerman wrote:
> > On Thu, 2015-02-07 at 23:02:02 UTC, Nishanth Aravamudan wrote:
> > >
> > > we currently emit at boot:
> > >
> > > [ 0.000000] pcpu-alloc: [0] 0 1 2 3 [0] 4 5 6 7
> > >
> > > After this commit, we correctly emit:
> > >
> > > [ 0.000000] pcpu-alloc: [0] 0 1 2 3 [1] 4 5 6 7
> >
> >
> > So it looks fairly sane, and I guess it's a bug fix.
> >
> > But I'm a bit reluctant to put it in straight away without some time in next.
>
> I'm fine with that -- it could use some more extensive testing,
> admittedly (I only have been able to verify the pcpu areas are being
> correctly allocated on the right node so far).
>
> I still need to test with hotplug and things like that. Hence the RFC.
>
> > It looks like the symptom is that the per-cpu areas are all allocated on node
> > 0, is that all that goes wrong?
>
> Yes, that's the symptom. I cc'd a few folks to see if they could help
> indicate the performance implications of such a setup -- sorry, I should
> have been more explicit about that.
OK cool. I'm happy to put it in next if you send a non-RFC version.
cheers
next prev parent reply other threads:[~2015-07-15 0:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 23:02 [RFC PATCH 1/2] powerpc/numa: fix cpu_to_node() usage during boot Nishanth Aravamudan
2015-07-02 23:03 ` [RFC PATCH 2/2] powerpc/smp: use early_cpu_to_node() instead of direct references to numa_cpu_lookup_table Nishanth Aravamudan
2015-07-09 1:25 ` David Rientjes
2015-07-08 4:00 ` [RFC,1/2] powerpc/numa: fix cpu_to_node() usage during boot Michael Ellerman
2015-07-08 23:16 ` Nishanth Aravamudan
2015-07-09 1:24 ` David Rientjes
2015-07-10 16:15 ` Nishanth Aravamudan
2015-07-15 20:37 ` Tejun Heo
2015-07-15 0:22 ` Michael Ellerman [this message]
2015-07-09 1:22 ` [RFC PATCH 1/2] " David Rientjes
2015-07-10 16:25 ` Nishanth Aravamudan
2015-07-14 21:31 ` David Rientjes
2015-07-15 20:35 ` Tejun Heo
2015-07-15 22:43 ` Nishanth Aravamudan
2015-07-15 22:47 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436919743.10956.2.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=anton@samba$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=nacc@linux$(echo .)vnet.ibm.com \
--cc=paulus@samba$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=rientjes@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox