From: Michael Ellerman <mpe@ellerman•id.au>
To: Kees Cook <keescook@chromium•org>
Cc: "linuxppc-dev@ozlabs•org" <linuxppc-dev@ozlabs•org>,
LKML <linux-kernel@vger•kernel.org>,
Andy Lutomirski <luto@amacapital•net>,
Will Drewry <wad@chromium•org>,
strosake@linux•vnet.ibm.com, bogdan.purcareata@freescale•com
Subject: Re: [RFC PATCH 09/12] powerpc/kernel: Add SIG_SYS support for compat tasks
Date: Thu, 16 Jul 2015 13:38:43 +1000 [thread overview]
Message-ID: <1437017923.28475.4.camel@ellerman.id.au> (raw)
In-Reply-To: <CAGXu5jKX2OsQz0by52ZahiFXn89u4YQ8WHNv7b1XkpL0W+yW_w@mail.gmail.com>
On Wed, 2015-07-15 at 08:12 -0700, Kees Cook wrote:
> On Wed, Jul 15, 2015 at 12:37 AM, Michael Ellerman <mpe@ellerman•id.au> wrote:
> > diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c
> > index c5abe7fd7590..b2374c131340 100644
> > --- a/tools/testing/selftests/seccomp/seccomp_bpf.c
> > +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c
> > @@ -645,6 +645,10 @@ static struct siginfo TRAP_info;
> > static volatile int TRAP_nr;
> > static void TRAP_action(int nr, siginfo_t *info, void *void_context)
> > {
> > + fprintf(stderr, "in TRAP_action\n");
> > + fprintf(stderr, "info->si_call_addr %p\n", info->si_call_addr);
> > + fprintf(stderr, "info->si_syscall %u\n", info->si_syscall);
> > + fprintf(stderr, "info->si_arch %u\n", info->si_arch);
> > memcpy(&TRAP_info, info, sizeof(TRAP_info));
> > TRAP_nr = nr;
> > }
>
> This chunk looks like left-over debugging?
Urgh yep, that's ugly. Thanks for noticing.
Will remove before merging :)
cheers
next prev parent reply other threads:[~2015-07-16 3:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 7:37 [RFC PATCH 01/12] powerpc/kernel: Get pt_regs from r9 before calling do_syscall_trace_enter() Michael Ellerman
2015-07-15 7:37 ` [RFC PATCH 02/12] powerpc/kernel: Switch to using MAX_ERRNO Michael Ellerman
2015-07-16 22:42 ` Benjamin Herrenschmidt
2015-07-15 7:37 ` [RFC PATCH 03/12] powerpc/kernel: Change the do_syscall_trace_enter() API Michael Ellerman
2015-07-15 7:37 ` [RFC PATCH 04/12] powerpc: Drop unused syscall_get_error() Michael Ellerman
2015-07-15 7:37 ` [RFC PATCH 05/12] powerpc: Don't negate error in syscall_set_return_value() Michael Ellerman
2015-07-15 7:37 ` [RFC PATCH 06/12] powerpc: Rework syscall_get_arguments() so there is only one loop Michael Ellerman
2015-07-15 7:37 ` [RFC PATCH 07/12] powerpc: Use orig_gpr3 in syscall_get_arguments() Michael Ellerman
2015-07-15 7:37 ` [RFC PATCH 08/12] powerpc: Change syscall_get_nr() to return int Michael Ellerman
2015-07-15 7:37 ` [RFC PATCH 09/12] powerpc/kernel: Add SIG_SYS support for compat tasks Michael Ellerman
2015-07-15 15:12 ` Kees Cook
2015-07-16 3:38 ` Michael Ellerman [this message]
2015-07-15 7:37 ` [RFC PATCH 10/12] powerpc/kernel: Enable seccomp filter Michael Ellerman
2015-07-15 7:37 ` [RFC PATCH 11/12] selftests/seccomp: Make seccomp tests work on big endian Michael Ellerman
2015-07-15 15:16 ` Kees Cook
2015-07-16 3:41 ` Michael Ellerman
2015-07-15 7:37 ` [RFC PATCH 12/12] selftests/seccomp: Add powerpc support Michael Ellerman
2015-07-15 15:16 ` Kees Cook
2015-07-16 22:40 ` [RFC PATCH 01/12] powerpc/kernel: Get pt_regs from r9 before calling do_syscall_trace_enter() Benjamin Herrenschmidt
2015-07-17 4:41 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437017923.28475.4.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=bogdan.purcareata@freescale$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=luto@amacapital$(echo .)net \
--cc=strosake@linux$(echo .)vnet.ibm.com \
--cc=wad@chromium$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox