From: Michael Ellerman <mpe@ellerman•id.au>
To: Anton Blanchard <anton@samba•org>
Cc: Ian Munsie <imunsie@au1•ibm.com>,
Benjamin Herrenschmidt <benh@au1•ibm.com>,
linuxppc-dev <linuxppc-dev@ozlabs•org>,
Michael Neuling <michael.neuling@au1•ibm.com>,
"sonal.santan" <sonal.santan@xilinx•com>,
Jeremy Kerr <jk@ozlabs•org>,
Samuel Mendoza-Jonas <sam.mj@au1•ibm.com>
Subject: Re: [PATCH] Fix crash due to processing "memory-controller" nodes as "memory"
Date: Tue, 21 Jul 2015 13:06:24 +1000 [thread overview]
Message-ID: <1437447984.30722.3.camel@ellerman.id.au> (raw)
In-Reply-To: <20150721124554.332dd228@kryten>
On Tue, 2015-07-21 at 12:45 +1000, Anton Blanchard wrote:
> Hi Ian,
>
> > From: Ian Munsie <imunsie@au1•ibm.com>
> >
> > If the system has a PCI device with a memory-controller device node,
> > kexec-lite would spew hundreds of double free warnings and eventually
> > segfault. This would result in a "kexec load failed" message from
> > petitboot.
> >
> > This was due to kexec_memory_map() searching for "memory" nodes, but
> > actually matching any node that started with "memory", including these
> > "memory-controller" nodes. This patch changes the search to look for
> > nodes starting with "memory@", which should only match memory nodes.
>
> Nice catch! I wonder if we should be checking for device_type
> "memory". Ben?
Yes. That's what Linux does.
cheers
next prev parent reply other threads:[~2015-07-21 3:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 8:20 [PATCH] Fix crash due to processing "memory-controller" nodes as "memory" Ian Munsie
2015-07-20 8:25 ` Ian Munsie
2015-07-21 2:45 ` Anton Blanchard
2015-07-21 2:54 ` Benjamin Herrenschmidt
2015-07-21 3:06 ` Michael Ellerman [this message]
2015-07-21 23:18 ` Anton Blanchard
2015-07-22 0:36 ` Ian Munsie
2015-07-22 5:15 ` Anton Blanchard
2015-07-22 0:39 ` Jeremy Kerr
2015-07-22 1:32 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437447984.30722.3.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=anton@samba$(echo .)org \
--cc=benh@au1$(echo .)ibm.com \
--cc=imunsie@au1$(echo .)ibm.com \
--cc=jk@ozlabs$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=michael.neuling@au1$(echo .)ibm.com \
--cc=sam.mj@au1$(echo .)ibm.com \
--cc=sonal.santan@xilinx$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox