From: Michael Ellerman <mpe@ellerman•id.au>
To: Daniel Axtens <dja@axtens•net>
Cc: linuxppc-dev@ozlabs•org, benh@kernel•crashing.org,
mikey@neuling•org, imunsie@au•ibm.com
Subject: Re: [PATCH] cxl: Don't ignore add_process_element result when attaching context
Date: Wed, 29 Jul 2015 14:25:32 +1000 [thread overview]
Message-ID: <1438143932.17434.1.camel@ellerman.id.au> (raw)
In-Reply-To: <1438142842-31603-1-git-send-email-dja@axtens.net>
On Wed, 2015-07-29 at 14:07 +1000, Daniel Axtens wrote:
> Previously, when attaching a context in dedicated mode, we ignored
Previously? You mean currently? Now is before this patch is applied.
> the result of add_process_element, which could potentially fail.
>
> If add_process_element returns and error, pass it back to the caller.
^
I can fix.
> Signed-off-by: Daniel Axtens <dja@axtens•net>
>
> ---
>
> I'm not sure if this is worth sending to stable: it doesn't fix
> any actual bug, it just lets us know earlier if we've failed.
>
> However, if mpe, Mikey or Ian feel like it should go to stable I
> have no objection to that either.
stable_kernel_rules.txt says:
- It must fix a real bug that bothers people (not a, "This could be a
problem..." type thing).
So I think not. But rules are flexible so I can be convinced otherwise if
anyone has a good argument.
cheers
next prev parent reply other threads:[~2015-07-29 4:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 4:07 [PATCH] cxl: Don't ignore add_process_element result when attaching context Daniel Axtens
2015-07-29 4:25 ` Michael Ellerman [this message]
2015-07-29 4:40 ` Daniel Axtens
2015-08-05 7:59 ` Michael Neuling
2015-08-10 9:27 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438143932.17434.1.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=benh@kernel$(echo .)crashing.org \
--cc=dja@axtens$(echo .)net \
--cc=imunsie@au$(echo .)ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mikey@neuling$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox