Subject: Re: [PATCH v5] powerpc/rcpm: add RCPM driver

From: Chenhui Zhao <[email-masked]>
Date: Mon, 3 Aug 2015 19:14:46 +0800

On Sat, Aug 1, 2015 at 8:45 AM, Scott Wood <[email-masked]> 
wrote:
> On Fri, 2015-06-26 at 15:44 +0800, [email-masked] wrote:
>>  +static void rcpm_v1_set_ip_power(bool enable, u32 *mask)
>>  +{
>>  +     if (enable)
>>  +             setbits32(&rcpm_v1_regs->ippdexpcr, *mask);
>>  +     else
>>  +             clrbits32(&rcpm_v1_regs->ippdexpcr, *mask);
>>  +}
>>  +
>>  +static void rcpm_v2_set_ip_power(bool enable, u32 *mask)
>>  +{
>>  +     if (enable)
>>  +             setbits32(&rcpm_v2_regs->ippdexpcr[0], *mask);
>>  +     else
>>  +             clrbits32(&rcpm_v2_regs->ippdexpcr[0], *mask);
>>  +}
> 
> Why do these take "u32 *mask" instead of "u32 mask"?
> 
> -Scott

I think it can be used in the case where there are several mask values.

-Chenhui