From: Scott Wood <scottwood@freescale•com>
To: Chenhui Zhao <chenhui.zhao@freescale•com>
Cc: <linuxppc-dev@lists•ozlabs.org>, <linux-kernel@vger•kernel.org>,
<Jason.Jin@freescale•com>
Subject: Re: [PATCH 3/4] powerpc: pm: add EPU FSM configuration for deep sleep
Date: Mon, 3 Aug 2015 16:22:51 -0500 [thread overview]
Message-ID: <1438636971.2097.66.camel@freescale.com> (raw)
In-Reply-To: <1438603291.7515.4@remotesmtp.freescale.net>
On Mon, 2015-08-03 at 20:01 +0800, Chenhui Zhao wrote:
> On Sat, Aug 1, 2015 at 8:41 AM, Scott Wood <scottwood@freescale•com>
> wrote:
> > On Fri, 2015-07-31 at 20:53 +0800, Chenhui Zhao wrote:
> > > In the last stage of deep sleep, software will trigger a Finite
> > > State Machine (FSM) to control the hardware precedure, such as
> > > board isolation, killing PLLs, removing power, and so on.
> > >
> > > When the system is waked up by an interrupt, the FSM controls the
> > > hardware to complete the early resume precedure.
> > >
> > > This patch configure the EPU FSM preparing for deep sleep.
> > >
> > > Signed-off-by: Chenhui Zhao <chenhui.zhao@freescale•com>
> > > ---
> > > arch/powerpc/platforms/85xx/Makefile | 2 +-
> > > arch/powerpc/platforms/85xx/sleep_fsm.c | 256
> > > ++++++++++++++++++++++++++++++++
> > > arch/powerpc/platforms/85xx/sleep_fsm.h | 104 +++++++++++++
> > > 3 files changed, 361 insertions(+), 1 deletion(-)
> > > create mode 100644 arch/powerpc/platforms/85xx/sleep_fsm.c
> > > create mode 100644 arch/powerpc/platforms/85xx/sleep_fsm.h
> >
> > When I asked why this was in drivers/platform[1], you said it was to
> > share
> > with LS1, and that the values used were the same -- so why did you
> > move it to
> > arch/powerpc?
>
> There are some changes. LS1 will use PSCI (Power State Coordination
> Interface) to implement deep sleep. So these code just used by PowerPC.
Then remove the comment about the values being usable on ls1021.
-Scott
next prev parent reply other threads:[~2015-08-03 21:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 12:53 [PATCH 1/4] powerpc/85xx: support sleep feature on QorIQ SoCs with RCPM Chenhui Zhao
2015-07-31 12:53 ` [PATCH 2/4] powerpc: get the physical base address of DCSR Chenhui Zhao
2015-07-31 12:53 ` [PATCH 3/4] powerpc: pm: add EPU FSM configuration for deep sleep Chenhui Zhao
2015-08-01 0:41 ` Scott Wood
2015-08-03 12:01 ` Chenhui Zhao
2015-08-03 21:22 ` Scott Wood [this message]
2015-07-31 12:53 ` [PATCH 4/4] powerpc: pm: support deep sleep feature on T104x Chenhui Zhao
2015-08-01 2:49 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438636971.2097.66.camel@freescale.com \
--to=scottwood@freescale$(echo .)com \
--cc=Jason.Jin@freescale$(echo .)com \
--cc=chenhui.zhao@freescale$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox