From: Michael Neuling <mikey@neuling•org>
To: Daniel Axtens <dja@axtens•net>
Cc: linuxppc-dev@ozlabs•org, imunsie@au•ibm.com
Subject: Re: [PATCH 2/4] cxl: sparse: Make declarations static
Date: Fri, 07 Aug 2015 15:48:52 +1000 [thread overview]
Message-ID: <1438926532.16275.9.camel@neuling.org> (raw)
In-Reply-To: <1438917500-12100-2-git-send-email-dja@axtens.net>
On Fri, 2015-08-07 at 13:18 +1000, Daniel Axtens wrote:
> A few declarations were identified by sparse as needing to be static:
>=20
> /scratch/dja/linux-capi/drivers/misc/cxl/irq.c:408:6: warning: symbol 'af=
u_irq_name_free' was not declared. Should it be static?
> /scratch/dja/linux-capi/drivers/misc/cxl/irq.c:467:6: warning: symbol 'af=
u_register_hwirqs' was not declared. Should it be static?
> /scratch/dja/linux-capi/drivers/misc/cxl/file.c:254:6: warning: symbol 'a=
fu_compat_ioctl' was not declared. Should it be static?
> /scratch/dja/linux-capi/drivers/misc/cxl/file.c:399:30: warning: symbol '=
afu_master_fops' was not declared. Should it be static?
>=20
> Make them static.
>=20
> Signed-off-by: Daniel Axtens <dja@axtens•net>
Acked-by: Michael Neuling <mikey@neuling•org>
> ---
> drivers/misc/cxl/file.c | 4 ++--
> drivers/misc/cxl/irq.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/misc/cxl/file.c b/drivers/misc/cxl/file.c
> index e3f4b69527a9..c8c8bfa2679b 100644
> --- a/drivers/misc/cxl/file.c
> +++ b/drivers/misc/cxl/file.c
> @@ -251,7 +251,7 @@ long afu_ioctl(struct file *file, unsigned int cmd, u=
nsigned long arg)
> return -EINVAL;
> }
> =20
> -long afu_compat_ioctl(struct file *file, unsigned int cmd,
> +static long afu_compat_ioctl(struct file *file, unsigned int cmd,
> unsigned long arg)
> {
> return afu_ioctl(file, cmd, arg);
> @@ -396,7 +396,7 @@ const struct file_operations afu_fops =3D {
> .mmap =3D afu_mmap,
> };
> =20
> -const struct file_operations afu_master_fops =3D {
> +static const struct file_operations afu_master_fops =3D {
> .owner =3D THIS_MODULE,
> .open =3D afu_master_open,
> .poll =3D afu_poll,
> diff --git a/drivers/misc/cxl/irq.c b/drivers/misc/cxl/irq.c
> index 680cd263436d..77e5d0e7ebe1 100644
> --- a/drivers/misc/cxl/irq.c
> +++ b/drivers/misc/cxl/irq.c
> @@ -405,7 +405,7 @@ void cxl_release_psl_irq(struct cxl_afu *afu)
> kfree(afu->psl_irq_name);
> }
> =20
> -void afu_irq_name_free(struct cxl_context *ctx)
> +static void afu_irq_name_free(struct cxl_context *ctx)
> {
> struct cxl_irq_name *irq_name, *tmp;
> =20
> @@ -464,7 +464,7 @@ out:
> return -ENOMEM;
> }
> =20
> -void afu_register_hwirqs(struct cxl_context *ctx)
> +static void afu_register_hwirqs(struct cxl_context *ctx)
> {
> irq_hw_number_t hwirq;
> struct cxl_irq_name *irq_name;
next prev parent reply other threads:[~2015-08-07 5:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 3:18 [PATCH 1/4] cxl: Compile with -Werror Daniel Axtens
2015-08-07 3:18 ` [PATCH 2/4] cxl: sparse: Make declarations static Daniel Axtens
2015-08-07 5:48 ` Michael Neuling [this message]
2015-08-13 1:44 ` [2/4] " Michael Ellerman
2015-08-07 3:18 ` [PATCH 3/4] cxl: sparse: Flag iomem pointers properly Daniel Axtens
2015-08-07 4:13 ` Michael Neuling
2015-08-12 3:19 ` [3/4] " Michael Ellerman
2015-08-07 3:18 ` [PATCH 4/4] cxl: sparse: Silence iomem warning in debugfs file creation Daniel Axtens
2015-08-07 4:13 ` Michael Neuling
2015-08-13 1:44 ` [4/4] " Michael Ellerman
2015-08-07 3:25 ` [PATCH 1/4] cxl: Compile with -Werror Michael Neuling
2015-08-07 3:26 ` Daniel Axtens
2015-08-07 4:13 ` Michael Neuling
2015-08-13 1:44 ` [1/4] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438926532.16275.9.camel@neuling.org \
--to=mikey@neuling$(echo .)org \
--cc=dja@axtens$(echo .)net \
--cc=imunsie@au$(echo .)ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox