From: Benjamin Herrenschmidt <benh@kernel•crashing.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux•vnet.ibm.com>,
paulus@samba•org, mpe@ellerman•id.au, ryabinin.a.a@gmail•com
Cc: linuxppc-dev@lists•ozlabs.org
Subject: Re: [RFC PATCH V1 0/8] KASAN ppc64 support
Date: Mon, 17 Aug 2015 16:54:52 +1000 [thread overview]
Message-ID: <1439794492.2416.8.camel@kernel.crashing.org> (raw)
In-Reply-To: <1439793400-18147-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
On Mon, 2015-08-17 at 12:06 +0530, Aneesh Kumar K.V wrote:
> Hi,
>
> This patchset implements kernel address sanitizer for ppc64.
> Since ppc64 virtual address range is divided into different regions,
> we can't have one contigous area for the kasan shadow range. Hence
> we don't support the INLINE kasan instrumentation. With Outline
> instrumentation, we override the shadow_to_mem and mem_to_shadow
> callbacks, so that we map only the kernel linear range (ie,
> region with ID 0xc). For region with ID 0xd and 0xf (vmalloc
> and vmemmap ) we return the address of the zero page. This
> works because kasan doesn't track both vmemmap and vmalloc address.
So bear with me, I don't know anything about KASAN, but if you want a
shadow, can't you just add a fixed offset to the address and thus
effectively shadow each region independently while keeping the inline
helpers ?
Cheers,
Ben.
> Aneesh Kumar K.V (8):
> powerpc/mm: Add virt_to_pfn and use this instead of opencoding
> kasan: MODULE_VADDR is not available on all archs
> kasan: Rename kasan_enabled to kasan_report_enabled
> kasan: Don't use kasan shadow pointer in generic functions
> kasan: Enable arch to hook into kasan callbacks.
> kasan: Allow arch to overrride kasan shadow offsets
> powerpc/mm: kasan: Add kasan support for ppc64
> powerpc: Disable kasan for kernel/ and mm/ directory
>
> -aneesh
>
> arch/powerpc/include/asm/kasan.h | 74
> ++++++++++++++++++++++++++++++++
> arch/powerpc/include/asm/page.h | 5 ++-
> arch/powerpc/include/asm/pgtable-ppc64.h | 1 +
> arch/powerpc/include/asm/ppc_asm.h | 10 +++++
> arch/powerpc/include/asm/string.h | 13 ++++++
> arch/powerpc/kernel/Makefile | 2 +
> arch/powerpc/kernel/prom_init_check.sh | 2 +-
> arch/powerpc/kernel/setup_64.c | 3 ++
> arch/powerpc/lib/mem_64.S | 6 ++-
> arch/powerpc/lib/memcpy_64.S | 3 +-
> arch/powerpc/lib/ppc_ksyms.c | 10 +++++
> arch/powerpc/mm/Makefile | 4 ++
> arch/powerpc/mm/kasan_init.c | 44 +++++++++++++++++++
> arch/powerpc/mm/slb_low.S | 4 ++
> arch/powerpc/platforms/Kconfig.cputype | 1 +
> include/linux/kasan.h | 3 ++
> mm/kasan/kasan.c | 9 ++++
> mm/kasan/kasan.h | 20 ++++++++-
> mm/kasan/report.c | 19 ++++----
> 19 files changed, 216 insertions(+), 17 deletions(-)
> create mode 100644 arch/powerpc/include/asm/kasan.h
> create mode 100644 arch/powerpc/mm/kasan_init.c
>
next prev parent reply other threads:[~2015-08-17 6:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 6:36 [RFC PATCH V1 0/8] KASAN ppc64 support Aneesh Kumar K.V
2015-08-17 6:36 ` [RFC PATCH V1 1/8] powerpc/mm: Add virt_to_pfn and use this instead of opencoding Aneesh Kumar K.V
2015-08-17 6:36 ` [RFC PATCH V1 2/8] kasan: MODULE_VADDR is not available on all archs Aneesh Kumar K.V
2015-08-17 6:36 ` [RFC PATCH V1 3/8] kasan: Rename kasan_enabled to kasan_report_enabled Aneesh Kumar K.V
2015-08-17 6:36 ` [RFC PATCH V1 4/8] kasan: Don't use kasan shadow pointer in generic functions Aneesh Kumar K.V
2015-08-17 11:36 ` Andrey Ryabinin
2015-08-18 5:29 ` Aneesh Kumar K.V
2015-08-18 9:12 ` Andrey Ryabinin
2015-08-17 6:36 ` [RFC PATCH V1 5/8] kasan: Enable arch to hook into kasan callbacks Aneesh Kumar K.V
2015-08-17 6:36 ` [RFC PATCH V1 6/8] kasan: Allow arch to overrride kasan shadow offsets Aneesh Kumar K.V
2015-08-17 6:36 ` [RFC PATCH V1 7/8] powerpc/mm: kasan: Add kasan support for ppc64 Aneesh Kumar K.V
2015-08-17 12:13 ` Andrey Ryabinin
2015-08-17 12:17 ` Andrey Ryabinin
2015-08-18 5:36 ` Aneesh Kumar K.V
2015-08-18 8:40 ` Andrey Ryabinin
2015-08-18 5:34 ` Aneesh Kumar K.V
2015-08-17 6:36 ` [RFC PATCH V1 8/8] powerpc: Disable kasan for kernel/ and mm/ directory Aneesh Kumar K.V
2015-08-17 6:54 ` Benjamin Herrenschmidt [this message]
2015-08-17 9:50 ` [RFC PATCH V1 0/8] KASAN ppc64 support Aneesh Kumar K.V
2015-08-17 10:01 ` Benjamin Herrenschmidt
2015-08-17 10:50 ` Aneesh Kumar K.V
2015-08-17 11:21 ` Benjamin Herrenschmidt
2015-08-17 11:29 ` Andrey Ryabinin
2015-08-18 5:42 ` Aneesh Kumar K.V
2015-08-18 8:50 ` Andrey Ryabinin
2015-08-18 9:21 ` Aneesh Kumar K.V
2015-08-18 9:30 ` Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439794492.2416.8.camel@kernel.crashing.org \
--to=benh@kernel$(echo .)crashing.org \
--cc=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
--cc=ryabinin.a.a@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox