From: Michael Ellerman <mpe@ellerman•id.au>
To: "Guilherme G. Piccoli" <gpiccoli@linux•vnet.ibm.com>
Cc: linuxppc-dev@lists•ozlabs.org, gwshan@linux•vnet.ibm.com,
benh@kernel•crashing.org, paulus@samba•org
Subject: Re: [PATCH 1/2] PCI: Make pci_msi_setup_pci_dev() non-static for use by arch code
Date: Wed, 19 Aug 2015 10:44:46 +1000 [thread overview]
Message-ID: <1439945086.23217.5.camel@ellerman.id.au> (raw)
In-Reply-To: <1439932430-13375-2-git-send-email-gpiccoli@linux.vnet.ibm.com>
Hi Guilherme,
Thanks for the patches.
On Tue, 2015-08-18 at 18:13 -0300, Guilherme G. Piccoli wrote:
> Commit 1851617cd2 ("PCI/MSI: Disable MSI at enumeration even if kernel
> doesn't support MSI") changed the location of the code that disables
> MSI/MSI-X interrupts at PCI probe time in devices that have this flag set.
> It moved the code from pci_msi_init_pci_dev() to a new function named
> pci_msi_setup_pci_dev(), called by pci_setup_device().
OK.
> Since then, the pSeries platform of the powerpc architecture needs to
> disable MSI at PCI probe time manually, as the code flow doesn't
> reach pci_setup_device().
>
> For doing so, it wants to call
> pci_msi_setup_pci_dev(). This patch makes the required function
> non-static, so that it will be called on PCI probe path on powerpc pSeries
> platform in next patch.
I didn't follow that entirely, I think you mean something like:
The pseries PCI probing code does not call pci_setup_device(), so since
commit 1851617cd2 pci_msi_setup_pci_dev() is not called and MSIs are left
enabled, which is a bug.
To fix this the pseries PCI probe should manually call
pci_msi_setup_pci_dev(), so make it non-static.
Does that look OK?
Also you haven't CC'ed the original author of the commit, or the PCI
maintainer, or the relevant lists.
That would be:
Michael S. Tsirkin <mst@redhat•com>
Bjorn Helgaas <bhelgaas@google•com>
linux-pci@vger•kernel.org
linux-kernel@vger•kernel.org
And finally both patches should have a fixes line, such as:
Fixes: 1851617cd2da ("PCI/MSI: Disable MSI at enumeration even if kernel doesn't support MSI")
cheers
next prev parent reply other threads:[~2015-08-19 0:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 21:13 [PATCH 0/2] Disable MSI/MSI-X interrupts manually at PCI probe time in PowerPC architecture Guilherme G. Piccoli
2015-08-18 21:13 ` [PATCH 1/2] PCI: Make pci_msi_setup_pci_dev() non-static for use by arch code Guilherme G. Piccoli
2015-08-19 0:44 ` Michael Ellerman [this message]
[not found] ` <1439932077-11427-2-git-send-email-gpiccoli@linux.vnet.ibm.com>
2015-08-19 18:45 ` [PATCH v2 " Guilherme G. Piccoli
2015-08-20 1:02 ` Michael Ellerman
2015-08-20 19:10 ` Guilherme G. Piccoli
2015-08-24 7:37 ` Michael Ellerman
2015-08-24 12:18 ` Guilherme G. Piccoli
2015-08-18 21:13 ` [PATCH 2/2] powerpc/PCI: Disable MSI/MSI-X interrupts at PCI probe time in OF case Guilherme G. Piccoli
[not found] ` <1439932077-11427-3-git-send-email-gpiccoli@linux.vnet.ibm.com>
2015-08-19 18:54 ` [PATCH v2 " Guilherme G. Piccoli
2015-09-03 17:56 ` Bjorn Helgaas
2015-09-04 23:17 ` Guilherme G. Piccoli
2015-09-04 22:59 ` jeclark2006
2015-09-06 14:44 ` Michael S. Tsirkin
2015-09-07 3:17 ` Michael Ellerman
2015-09-07 23:04 ` Guilherme G. Piccoli
2015-09-15 16:18 ` Bjorn Helgaas
2015-10-08 16:05 ` Guilherme G. Piccoli
2015-09-07 3:10 ` Michael Ellerman
2015-09-07 23:07 ` Guilherme G. Piccoli
-- strict thread matches above, loose matches on Subject: below --
2015-08-24 12:42 [PATCH 1/2] PCI: Make pci_msi_setup_pci_dev() non-static for use by arch code Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439945086.23217.5.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=benh@kernel$(echo .)crashing.org \
--cc=gpiccoli@linux$(echo .)vnet.ibm.com \
--cc=gwshan@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox