From: Michael Ellerman <mpe@ellerman•id.au>
To: Alexey Kardashevskiy <aik@ozlabs•ru>
Cc: linuxppc-dev@lists•ozlabs.org,
Wei Yang <weiyang@linux•vnet.ibm.com>,
Gavin Shan <gwshan@linux•vnet.ibm.com>
Subject: Re: [kernel] powerpc/iommu: Set default DMA offset in dma_dev_setup
Date: Fri, 28 Aug 2015 13:23:45 +1000 [thread overview]
Message-ID: <1440732225.8076.4.camel@ellerman.id.au> (raw)
In-Reply-To: <55DF0BA8.9080805@ozlabs.ru>
On Thu, 2015-08-27 at 23:07 +1000, Alexey Kardashevskiy wrote:
> On 08/27/2015 07:37 PM, Michael Ellerman wrote:
> > On Thu, 2015-27-08 at 06:01:16 UTC, Alexey Kardashevskiy wrote:
> >> "powerpc/iommu: Cleanup setting of DMA base/offset" expects that
> >
> > This should be:
> >
> > Commit e91c25111aa3 "powerpc/iommu: Cleanup setting of DMA base/offset" ...
>
> Is not this format for reverts (which this patch is not)?
No, it's for any time you reference a commit in a change log.
> >> Makes sense to squash it to "powerpc/iommu: Cleanup setting of DMA base/offset".
> >
> > We don't squash things that are already in next.
>
> imho this screams for rebase. There is no point in having broken patches in
> non merged tree, rebase is a very cheap operation.
You can scream all you like.
Scott has already forked my next as the basis for his next, so if I rebased my
tree we'd get duplicate copies of all of that, and conflicts everywhere.
cheers
next prev parent reply other threads:[~2015-08-28 3:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 6:01 [PATCH kernel] powerpc/iommu: Set default DMA offset in dma_dev_setup Alexey Kardashevskiy
2015-08-27 6:16 ` Gavin Shan
2015-08-27 7:41 ` Alexey Kardashevskiy
2015-08-27 9:37 ` [kernel] " Michael Ellerman
2015-08-27 13:07 ` Alexey Kardashevskiy
2015-08-28 3:23 ` Michael Ellerman [this message]
2015-08-27 21:58 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440732225.8076.4.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=aik@ozlabs$(echo .)ru \
--cc=gwshan@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=weiyang@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox