Subject: Re: [kernel] powerpc/iommu: Set default DMA offset in dma_dev_setup

From: Michael Ellerman <[email-masked]>
Date: Fri, 28 Aug 2015 13:23:45 +1000

On Thu, 2015-08-27 at 23:07 +1000, Alexey Kardashevskiy wrote:
> On 08/27/2015 07:37 PM, Michael Ellerman wrote:
> > On Thu, 2015-27-08 at 06:01:16 UTC, Alexey Kardashevskiy wrote:
> >> "powerpc/iommu: Cleanup setting of DMA base/offset" expects that
> >
> > This should be:
> >
> > Commit e91c25111aa3 "powerpc/iommu: Cleanup setting of DMA base/offset" ...
> 
> Is not this format for reverts (which this patch is not)?

No, it's for any time you reference a commit in a change log.

> >> Makes sense to squash it to "powerpc/iommu: Cleanup setting of DMA base/offset".
> >
> > We don't squash things that are already in next.
> 
> imho this screams for rebase. There is no point in having broken patches in 
> non merged tree, rebase is a very cheap operation.

You can scream all you like.

Scott has already forked my next as the basis for his next, so if I rebased my
tree we'd get duplicate copies of all of that, and conflicts everywhere.

cheers