Subject: Re: [PATCH][RESEND] cxl: Set up and enable PSL Timebase

From: Michael Ellerman <[email-masked]>
Date: Sun, 30 Aug 2015 18:56:05 +1000

On Fri, 2015-08-28 at 09:37 +0200, Philippe Bergheaud wrote:
> This patch configures the PSL Timebase function and enables it,
> after the CAPP has been initialized by OPAL.
> 
> Acked-by: Ian Munsie <[email-masked]>
> Signed-off-by: Philippe Bergheaud <[email-masked]>
> ---
>   drivers/misc/cxl/cxl.h |  5 +++++
>   drivers/misc/cxl/pci.c | 57 +++++++++++++++++++++++++++++++++++++++++++++++++-
>   2 files changed, 61 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/cxl/cxl.h b/drivers/misc/cxl/cxl.h
> index e7af256..19489c6 100644
> --- a/drivers/misc/cxl/cxl.h
> +++ b/drivers/misc/cxl/cxl.h
> @@ -83,8 +83,10 @@ static const cxl_p1_reg_t CXL_PSL_AFUSEL  = {0x00B0};
>   /* 0x00C0:7EFF Implementation dependent area */
>   static const cxl_p1_reg_t CXL_PSL_FIR1      = {0x0100};
>   static const cxl_p1_reg_t CXL_PSL_FIR2      = {0x0108};
> +static const cxl_p1_reg_t CXL_PSL_Timebase  = {0x0110};
>   static const cxl_p1_reg_t CXL_PSL_VERSION   = {0x0118};
>   static const cxl_p1_reg_t CXL_PSL_RESLCKTO  = {0x0128};
> +static const cxl_p1_reg_t CXL_PSL_TB_CTLSTAT = {0x0140};
>   static const cxl_p1_reg_t CXL_PSL_FIR_CNTL  = {0x0148};
>   static const cxl_p1_reg_t CXL_PSL_DSNDCTL   = {0x0150};
>   static const cxl_p1_reg_t CXL_PSL_SNWRALLOC = {0x0158};

The whitespace here is all fubar, see the double spaces on the context lines.

I've fixed it up this time, but please try and fix your mailer, I think you're
using Thunderbird? :

  https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/email-clients.txt#n209

cheers