From: Benjamin Herrenschmidt <benh@au1•ibm.com>
To: Paul Mackerras <paulus@ozlabs•org>
Cc: Thomas Huth <thuth@redhat•com>,
kvm-ppc@vger•kernel.org, Alexander Graf <agraf@suse•com>,
linuxppc-dev@lists•ozlabs.org, kvm@vger•kernel.org
Subject: Re: [PATCH] KVM: ppc: Fix size of the PSPB register
Date: Wed, 02 Sep 2015 08:55:07 +1000 [thread overview]
Message-ID: <1441148107.2668.57.camel@au1.ibm.com> (raw)
In-Reply-To: <20150901224521.GC23007@fergus.ozlabs.ibm.com>
On Wed, 2015-09-02 at 08:45 +1000, Paul Mackerras wrote:
> On Wed, Sep 02, 2015 at 08:25:05AM +1000, Benjamin Herrenschmidt
> wrote:
> > On Tue, 2015-09-01 at 23:41 +0200, Thomas Huth wrote:
> > > The size of the Problem State Priority Boost Register is only
> > > 32 bits, so let's change the type of the corresponding variable
> > > accordingly to avoid future trouble.
> >
> > It's not future trouble, it's broken today for LE and this should
> > fix
> > it BUT ....
>
> No, it's broken today for BE hosts, which will always see 0 for the
> PSPB register value. LE hosts are fine.
0 or PSPB << 32 ?
> > The asm accesses it using lwz/stw and C accesses it as a ulong. On
> > LE
> > that will mean that userspace will see the value << 32
>
> No, that will happen on BE, and since KVM_REG_PPC_PSPB says it's a
> 32-bit register, we'll just pass 0 back to userspace when it reads
> it.
Ah ok, I missed that bit about KVM_REG_PPC_PSPB
> > Now "fixing" it might break migration if that field is already
> > stored/loaded in its "broken" form. We may have to keep the
> > "broken"
> > behaviour and document that qemu sees a value shifted by 32.
>
> It will be being set to 0 on BE hosts across migration today
> (fortunately 0 is a benign value for PSPB). If we fix this on both
> the source and destination host, then the value will get migrated
> across correctly.
Ok, I missed the part where KVM_REG_PPC_PSPB passed it down as a 32
-bit. That means Thomas patch should work indeed.
> I think Thomas's patch is fine, it just needs a stronger patch
> description saying that it fixes an actual bug.
Right.
Cheers,
Ben.
next prev parent reply other threads:[~2015-09-01 22:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 21:41 [PATCH] KVM: ppc: Fix size of the PSPB register Thomas Huth
2015-09-01 22:24 ` Paul Mackerras
2015-09-01 22:30 ` Benjamin Herrenschmidt
2015-09-02 7:16 ` Thomas Huth
2015-09-01 22:25 ` Benjamin Herrenschmidt
2015-09-01 22:45 ` Paul Mackerras
2015-09-01 22:55 ` Benjamin Herrenschmidt [this message]
2015-09-02 7:26 ` Thomas Huth
2015-09-02 8:26 ` Alexander Graf
2015-09-02 8:35 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441148107.2668.57.camel@au1.ibm.com \
--to=benh@au1$(echo .)ibm.com \
--cc=agraf@suse$(echo .)com \
--cc=kvm-ppc@vger$(echo .)kernel.org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@ozlabs$(echo .)org \
--cc=thuth@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox