From: Michael Ellerman <mpe@ellerman•id.au>
To: Nishanth Aravamudan <nacc@linux•vnet.ibm.com>
Cc: Alexey Kardashevskiy <aik@ozlabs•ru>,
Hari Bathini <hbathini@linux•vnet.ibm.com>,
Gavin Shan <gwshan@linux•vnet.ibm.com>,
Ben Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
David Gibson <david@gibson•dropbear.id.au>,
Wei Yang <weiyang@linux•vnet.ibm.com>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v2] powerpc/powernv/pci-ioda: fix 32-bit TCE table init in kdump kernel
Date: Fri, 04 Sep 2015 19:57:15 +1000 [thread overview]
Message-ID: <1441360635.3777.1.camel@ellerman.id.au> (raw)
In-Reply-To: <20150903155944.GD47557@linux.vnet.ibm.com>
On Thu, 2015-09-03 at 08:59 -0700, Nishanth Aravamudan wrote:
> On 03.09.2015 [19:58:53 +1000], Michael Ellerman wrote:
> > On Wed, 2015-09-02 at 08:39 -0700, Nishanth Aravamudan wrote:
> > > On 02.09.2015 [19:00:31 +1000], Alexey Kardashevskiy wrote:
> > > > On 09/02/2015 11:11 AM, Nishanth Aravamudan wrote:
> > > > >diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
> > > > >index 85cbc96eff6c..0d7967e31169 100644
> > > > >--- a/arch/powerpc/platforms/powernv/pci-ioda.c
> > > > >+++ b/arch/powerpc/platforms/powernv/pci-ioda.c
> > > > >@@ -2077,10 +2077,17 @@ static long pnv_pci_ioda2_setup_default_config(struct pnv_ioda_pe *pe)
> > > > > {
> > > > > struct iommu_table *tbl = NULL;
> > > > > long rc;
> > > > >+ /*
> > > > >+ * In memory constrained environments, e.g. kdump kernel, the
> > > > >+ * DMA window can be larger than available memory, which will
> > > > >+ * cause errors later.
> > > > >+ */
> > > > >+ __u64 window_size =
> > > >
> > > > I asked for "const __u64" ;)
> > >
> > > I knew I'd forget something!
> >
> > Nish! In future please send a reply with the above comment, and then
> > the v2 as a separate mail, otherwise I have to manually edit out your
> > comment when applying.
>
> Sorry! Will amend my practices in the future.
Thanks.
I concede none of this is documented anywhere, maybe one day I'll have the time
to do that :)
> > > Fixes: aca6913f5551 ("powerpc/powernv/ioda2: Introduce helpers to allocate TCE pages")
> >
> > That went into 4.2, so should this have a:
> >
> > Cc: stable@vger•kernel.org # 4.2
>
> Grr, another mess-up, you're right, it should. Can you amend on your
> end? Sorry, I was in too much of a hurry to get the fixlet out.
That's OK, I'll fix it up.
cheers
next prev parent reply other threads:[~2015-09-04 9:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 1:11 [PATCH] powerpc/powernv/pci-ioda: fix 32-bit TCE table init in kdump kernel Nishanth Aravamudan
2015-09-02 9:00 ` Alexey Kardashevskiy
2015-09-02 15:39 ` [PATCH v2] " Nishanth Aravamudan
2015-09-03 9:58 ` Michael Ellerman
2015-09-03 15:59 ` Nishanth Aravamudan
2015-09-04 9:57 ` Michael Ellerman [this message]
2015-09-04 3:41 ` Alexey Kardashevskiy
2015-09-04 10:03 ` Michael Ellerman
2015-09-08 12:05 ` [v2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441360635.3777.1.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=aik@ozlabs$(echo .)ru \
--cc=benh@kernel$(echo .)crashing.org \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=gwshan@linux$(echo .)vnet.ibm.com \
--cc=hbathini@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=nacc@linux$(echo .)vnet.ibm.com \
--cc=paulus@samba$(echo .)org \
--cc=weiyang@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox