From: Michael Ellerman <mpe@ellerman•id.au>
To: Marc Zyngier <marc.zyngier@arm•com>
Cc: Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
Will Deacon <will.deacon@arm•com>,
Bjorn Helgaas <bhelgaas@google•com>,
Suravee Suthikulpanit <Suravee.Suthikulpanit@amd•com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm•com>,
Grant Likely <grant.likely@linaro•org>,
Rob Herring <robh+dt@kernel•org>, Alexander Graf <agraf@suse•de>,
linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linuxppc-dev@lists•ozlabs.org, linux-pci@vger•kernel.org,
devicetree@vger•kernel.org, Anton Blanchard <anton@samba•org>
Subject: Re: [PATCH v4 3/4] powerpc: PCI: Fix lookup of linux,pci-probe-only property
Date: Mon, 07 Sep 2015 18:59:43 +1000 [thread overview]
Message-ID: <1441616383.8979.4.camel@ellerman.id.au> (raw)
In-Reply-To: <1441385411-7624-4-git-send-email-marc.zyngier@arm.com>
On Fri, 2015-09-04 at 17:50 +0100, Marc Zyngier wrote:
> When find_and_init_phbs() looks for the probe-only property, it seems
> to trust the firmware to be correctly written, and assumes that there
> is a parameter to the property.
>
> It is conceivable that the firmware could not be that perfect, and it
> could expose this property naked (at least one arm64 platform seems to
> exhibit this exact behaviour). The setup code the ends up making
> a decision based on whatever the property pointer points to, which
> is likely to be junk.
>
> Instead, switch to the common of_pci.c implementation that doesn't
> suffer from this problem and ignore the property if the firmware
> couldn't make up its mind.
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm•com>
> ---
> arch/powerpc/platforms/pseries/setup.c | 14 ++------------
Thanks.
I can't find any powerpc machine that is currently using this, or much info on
what ever did use it, so I think it's pretty low impact, and the change looks
sane.
Acked-by: Michael Ellerman <mpe@ellerman•id.au>
cheers
next prev parent reply other threads:[~2015-09-07 8:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 16:50 [PATCH v4 0/4] PCI: arm64/powerpc: Fix parsing of linux, pci-probe-only Marc Zyngier
2015-09-04 16:50 ` [PATCH v4 1/4] of/pci: Add of_pci_check_probe_only to parse "linux, pci-probe-only" Marc Zyngier
2015-09-04 19:19 ` Rob Herring
2015-09-04 16:50 ` [PATCH v4 2/4] PCI: pci-host-generic: Fix lookup of linux, pci-probe-only property Marc Zyngier
2015-09-07 9:15 ` [PATCH v4 2/4] PCI: pci-host-generic: Fix lookup of linux,pci-probe-only property Will Deacon
2015-09-04 16:50 ` [PATCH v4 3/4] powerpc: PCI: Fix lookup of linux, pci-probe-only property Marc Zyngier
2015-09-07 8:59 ` Michael Ellerman [this message]
2015-09-04 16:50 ` [PATCH v4 4/4] arm64: dts: Drop linux, pci-probe-only from the Seattle DTS Marc Zyngier
2015-09-04 18:52 ` [PATCH v4 0/4] PCI: arm64/powerpc: Fix parsing of linux, pci-probe-only Rob Herring
2015-09-17 15:30 ` [PATCH v4 0/4] PCI: arm64/powerpc: Fix parsing of linux,pci-probe-only Bjorn Helgaas
2015-09-17 17:17 ` [PATCH v4 0/4] PCI: arm64/powerpc: Fix parsing of linux, pci-probe-only Marc Zyngier
2015-09-17 17:21 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441616383.8979.4.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=Suravee.Suthikulpanit@amd$(echo .)com \
--cc=agraf@suse$(echo .)de \
--cc=anton@samba$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bhelgaas@google$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=grant.likely@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lorenzo.pieralisi@arm$(echo .)com \
--cc=marc.zyngier@arm$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=robh+dt@kernel$(echo .)org \
--cc=will.deacon@arm$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox