From: Michael Ellerman <mpe@ellerman•id.au>
To: Nishanth Aravamudan <nacc@linux•vnet.ibm.com>
Cc: Hari Bathini <hbathini@in•ibm.com>,
Gavin Shan <gwshan@linux•vnet.ibm.com>,
Alexey Kardashevskiy <aik@ozlabs•ru>,
Ben Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
David Gibson <david@gibson•dropbear.id.au>,
Wei Yang <weiyang@linux•vnet.ibm.com>,
linuxppc-dev@lists•ozlabs.org, Jan Stancek <jstancek@redhat•com>
Subject: Re: [PATCH v2] powerpc/powernv/pci-ioda: fix kdump with non-power-of-2 crashkernel=
Date: Mon, 07 Sep 2015 19:19:09 +1000 [thread overview]
Message-ID: <1441617549.8979.5.camel@ellerman.id.au> (raw)
In-Reply-To: <20150904182252.GN47557@linux.vnet.ibm.com>
On Fri, 2015-09-04 at 11:22 -0700, Nishanth Aravamudan wrote:
> The 32-bit TCE table initialization relies on the DMA window having a
> size equal to a power of 2 (and checks for it explicitly). But
> crashkernel= has no constraint that requires a power-of-2 be specified.
> This causes the kdump kernel to fail to boot as none of the PCI devices
> (including the disk controller) are successfully initialized.
>
> After this change, the PCI devices successfully set up the 32-bit TCE
> table and kdump succeeds.
>
> Fixes: aca6913f5551 ("powerpc/powernv/ioda2: Introduce helpers to allocate TCE pages")
> Signed-off-by: Nishanth Aravamudan <nacc@linux•vnet.ibm.com>
> Cc: stable@vger•kernel.org # 4.2
>
> Michael, I kept this as a follow-on patch to my previous one. If you'd
> rather I made a v3 of that patch with the two fixes combined, I can
> resend.
No that's fine. I guess they could have been a single fix, but it's not a big deal.
> Also, I fixed up the context on my end to be u64, but not sure
> if that will match your tree (next doesn't have my prior patch applied
> yet, that I can see).
next isn't open yet, because we're still in the merge window, ie. rc1 hasn't
come out yet.
This is a fix so it'll go to my fixes branch. Whether I send that to Linus
before or after rc1 depends on how urgent the fixes people send me are. Sounds
like you'd like these two to go in asap?
cheers
next prev parent reply other threads:[~2015-09-07 9:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 18:22 [PATCH v2] powerpc/powernv/pci-ioda: fix kdump with non-power-of-2 crashkernel= Nishanth Aravamudan
2015-09-04 19:03 ` Jan Stancek
2015-09-07 9:19 ` Michael Ellerman [this message]
2015-09-08 3:10 ` Nishanth Aravamudan
2015-09-08 12:05 ` [v2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441617549.8979.5.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=aik@ozlabs$(echo .)ru \
--cc=benh@kernel$(echo .)crashing.org \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=gwshan@linux$(echo .)vnet.ibm.com \
--cc=hbathini@in$(echo .)ibm.com \
--cc=jstancek@redhat$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=nacc@linux$(echo .)vnet.ibm.com \
--cc=paulus@samba$(echo .)org \
--cc=weiyang@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox