From: Michael Ellerman <mpe@ellerman•id.au>
To: Raghavendra K T <raghavendra.kt@linux•vnet.ibm.com>
Cc: benh@kernel•crashing.org, paulus@samba•org, anton@samba•org,
akpm@linux-foundation•org, nacc@linux•vnet.ibm.com,
gkurz@linux•vnet.ibm.com, grant.likely@linaro•org,
nikunj@linux•vnet.ibm.com, vdavydov@parallels•com,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org,
linux-mm@kvack•org
Subject: Re: [PATCH V2 2/2] powerpc:numa Do not allocate bootmem memory for non existing nodes
Date: Tue, 22 Sep 2015 15:29:03 +1000 [thread overview]
Message-ID: <1442899743.18408.5.camel@ellerman.id.au> (raw)
In-Reply-To: <1442282917-16893-3-git-send-email-raghavendra.kt@linux.vnet.ibm.com>
On Tue, 2015-09-15 at 07:38 +0530, Raghavendra K T wrote:
>
> ... nothing
Sure this patch looks obvious, but please give me a changelog that proves
you've thought about it thoroughly.
For example is it OK to use for_each_node() at this point in boot? Is there any
historical reason why we did it with a hard coded loop? If so what has changed.
What systems have you tested on? etc. etc.
cheers
> Signed-off-by: Raghavendra K T <raghavendra.kt@linux•vnet.ibm.com>
> ---
> arch/powerpc/mm/numa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
> index 8b9502a..8d8a541 100644
> --- a/arch/powerpc/mm/numa.c
> +++ b/arch/powerpc/mm/numa.c
> @@ -80,7 +80,7 @@ static void __init setup_node_to_cpumask_map(void)
> setup_nr_node_ids();
>
> /* allocate the map */
> - for (node = 0; node < nr_node_ids; node++)
> + for_each_node(node)
> alloc_bootmem_cpumask_var(&node_to_cpumask_map[node]);
>
> /* cpumask_of_node() will now work */
next prev parent reply other threads:[~2015-09-22 5:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 2:08 [PATCH V2 0/2] Replace nr_node_ids for loop with for_each_node Raghavendra K T
2015-09-15 2:08 ` [PATCH V2 1/2] mm: Replace nr_node_ids for loop with for_each_node in list lru Raghavendra K T
2015-09-15 2:17 ` Raghavendra K T
2015-09-15 7:59 ` Vladimir Davydov
2015-09-15 2:08 ` [PATCH V2 2/2] powerpc:numa Do not allocate bootmem memory for non existing nodes Raghavendra K T
2015-09-22 5:29 ` Michael Ellerman [this message]
2015-09-22 10:48 ` Raghavendra K T
2015-09-22 19:36 ` Raghavendra K T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442899743.18408.5.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=akpm@linux-foundation$(echo .)org \
--cc=anton@samba$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=gkurz@linux$(echo .)vnet.ibm.com \
--cc=grant.likely@linaro$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=nacc@linux$(echo .)vnet.ibm.com \
--cc=nikunj@linux$(echo .)vnet.ibm.com \
--cc=paulus@samba$(echo .)org \
--cc=raghavendra.kt@linux$(echo .)vnet.ibm.com \
--cc=vdavydov@parallels$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox