Subject: Re: [net-next v4 3/8] dpaa_eth: add support for S/G frames

From: Joe Perches <[email-masked]>
Date: Mon, 02 Nov 2015 13:03:23 -0800

On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote:
> Add support for Scater/Gather (S/G) frames. The FMan can place
> the frame content into multiple buffers and provide a S/G Table
> (SGT) into one first buffer with references to the others.

trivia:

> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.h b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.h
[]
> @@ -347,7 +347,7 @@ static inline void clear_fd(struct qm_fd *fd)
>  }
>  
>  static inline int _dpa_tx_fq_to_id(const struct dpa_priv_s *priv,
> -				   struct qman_fq *tx_fq)
> +		struct qman_fq *tx_fq)

superfluous change?

> +void dpa_release_sgt(struct qm_sg_entry *sgt)
> +{
> +	struct dpa_bp *dpa_bp;
> +	struct bm_buffer bmb[DPA_BUFF_RELEASE_MAX];
> +	u8 i = 0, j;

Using int may be better than u8 for indexing