From: Scott Wood <scottwood@freescale•com>
To: Dogra Raghav-B46184 <raghav@freescale•com>
Cc: Kushwaha Prabhakar-B32579 <prabhakar@freescale•com>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH 1/2] mpc85xx/lbc: modify suspend/resume entry sequence
Date: Tue, 3 Nov 2015 01:36:37 -0600 [thread overview]
Message-ID: <1446536197.22185.61.camel@freescale.com> (raw)
In-Reply-To: <BY2PR0301MB07750650283AD03A00191EDFD22B0@BY2PR0301MB0775.namprd03.prod.outlook.com>
On Tue, 2015-11-03 at 00:33 -0600, Dogra Raghav-B46184 wrote:
> Hi Scott,
>
> I just checked on patchwork and noticed that the original patch has been
> modified as somehow my original comment has become part of the patch:
> + if (!lbc)
> + goto out;
>
> ctrl->saved_regs = kmalloc(sizeof(struct fsl_lbc_regs), GFP_KERNEL);
> if (!ctrl->saved_regs)
> return -ENOMEM;
> [Dogra Raghav-B46184] This is the existing upstream code. Are you
> suggesting to modify the upstream code to take care of individual registers?
>
> _memcpy_fromio(ctrl->saved_regs, lbc, sizeof(struct fsl_lbc_regs));
> +
> The patchwork is also showing two links for the patch. Please apply the
> original patch present at:
> https://patchwork.ozlabs.org/patch/538605/
>
> I will look into how this happened to avoid such incidents in future.
Your reply looked like a new patch, so Patchwork treated it as such. If you
fix your mailer to use proper quote markers (the > at the beginning of each
line) then this won't happen.
-Scott
next prev parent reply other threads:[~2015-11-03 7:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 6:24 [PATCH 1/2] mpc85xx/lbc: modify suspend/resume entry sequence Raghav Dogra
2015-10-30 20:03 ` Scott Wood
2015-11-02 6:12 ` Dogra Raghav
2015-11-02 23:00 ` Scott Wood
2015-11-03 5:31 ` Dogra Raghav
2015-11-03 5:39 ` Scott Wood
2015-11-03 6:09 ` Dogra Raghav
2015-11-03 6:13 ` Scott Wood
2015-11-03 6:33 ` Dogra Raghav
2015-11-03 7:36 ` Scott Wood [this message]
2015-11-03 9:12 ` Dogra Raghav
2015-12-23 21:10 ` Scott Wood
2015-12-24 4:19 ` [1/2] " Scott Wood
2015-12-24 4:38 ` Kushwaha Prabhakar
2015-12-24 4:49 ` Scott Wood
2015-12-24 5:22 ` Kushwaha Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446536197.22185.61.camel@freescale.com \
--to=scottwood@freescale$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=prabhakar@freescale$(echo .)com \
--cc=raghav@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox