From: Michael Ellerman <mpe@ellerman•id.au>
To: Torsten Duwe <duwe@lst•de>, Ian Munsie <imunsie@au1•ibm.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs•org>,
Michael Neuling <mikey@neuling•org>,
Anton Blanchard <anton@au1•ibm.com>,
Michael Ellerman <michaele@au1•ibm.com>
Subject: Re: [PATCH] cxl: Fix build failure due to -Wunused-variable behaviour change
Date: Thu, 26 Nov 2015 10:41:53 +1100 [thread overview]
Message-ID: <1448494913.22705.3.camel@ellerman.id.au> (raw)
In-Reply-To: <20151125161616.GA30262@lst.de>
On Wed, 2015-11-25 at 17:16 +0100, Torsten Duwe wrote:
> On Tue, Sep 15, 2015 at 03:48:34PM +1000, Ian Munsie wrote:
> > --- a/drivers/misc/cxl/Makefile
> > +++ b/drivers/misc/cxl/Makefile
> > @@ -1,4 +1,4 @@
> > -ccflags-y := -Werror
> > +ccflags-y := -Werror -Wno-unused-const-variable
>
> JFYI, my gcc-4.3 does not like this switch.
> What's the minimum compiler version to build this code?
I build everything with gcc 4.4.4, so if it breaks with that I will notice.
Does it work if you wrap it in cc-option? eg:
ccflags-y := -Werror $(call cc-option,-Wno-unused-const-variable)
cheers
next prev parent reply other threads:[~2015-11-25 23:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 5:48 [PATCH] cxl: Fix build failure due to -Wunused-variable behaviour change Ian Munsie
2015-09-17 5:13 ` Michael Ellerman
2015-11-25 16:16 ` [PATCH] " Torsten Duwe
2015-11-25 22:58 ` Anton Blanchard
2015-11-25 23:41 ` Michael Ellerman [this message]
2015-12-01 14:47 ` Torsten Duwe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448494913.22705.3.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=anton@au1$(echo .)ibm.com \
--cc=duwe@lst$(echo .)de \
--cc=imunsie@au1$(echo .)ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=michaele@au1$(echo .)ibm.com \
--cc=mikey@neuling$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox