From: Mathieu Desnoyers <mathieu.desnoyers@efficios•com>
To: Michael Ellerman <mpe@ellerman•id.au>
Cc: Peter Zijlstra <peterz@infradead•org>,
"Paul E. McKenney" <paulmck@linux•vnet.ibm.com>,
Boqun Feng <boqun.feng@gmail•com>,
Andy Lutomirski <luto@amacapital•net>,
Dave Watson <davejwatson@fb•com>,
linux-kernel <linux-kernel@vger•kernel.org>,
linux-api <linux-api@vger•kernel.org>,
Paul Turner <pjt@google•com>,
Andrew Morton <akpm@linux-foundation•org>,
Russell King <linux@arm•linux.org.uk>,
Thomas Gleixner <tglx@linutronix•de>,
Ingo Molnar <mingo@redhat•com>, "H. Peter Anvin" <hpa@zytor•com>,
Andrew Hunter <ahh@google•com>, Andi Kleen <andi@firstfloor•org>,
Chris Lameter <cl@linux•com>, Ben Maurer <bmaurer@fb•com>,
rostedt <rostedt@goodmis•org>,
Josh Triplett <josh@joshtriplett•org>,
Linus Torvalds <torvalds@linux-foundation•org>,
Catalin Marinas <catalin.marinas@arm•com>,
Will Deacon <will.deacon@arm•com>,
Michael Kerrisk <mtk.manpages@gmail•com>,
Joel Fernandes <joelaf@google•com>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [RFC PATCH for 4.18 09/16] powerpc: Add syscall detection for restartable sequences
Date: Tue, 5 Jun 2018 08:50:10 -0400 (EDT) [thread overview]
Message-ID: <1448764618.5559.1528203010706.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <871sdlbyg7.fsf@concordia.ellerman.id.au>
----- On Jun 5, 2018, at 1:21 AM, Michael Ellerman mpe@ellerman•id.au wrote:
> Mathieu Desnoyers <mathieu.desnoyers@efficios•com> writes:
>> From: Boqun Feng <boqun.feng@gmail•com>
>>
>> Syscalls are not allowed inside restartable sequences, so add a call to
>> rseq_syscall() at the very beginning of system call exiting path for
>> CONFIG_DEBUG_RSEQ=y kernel. This could help us to detect whether there
>> is a syscall issued inside restartable sequences.
>>
>> [ Tested on 64-bit powerpc kernel by Mathieu Desnoyers. Still needs to
>> be tested on 32-bit powerpc kernel. ]
>>
>> Signed-off-by: Boqun Feng <boqun.feng@gmail•com>
>> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios•com>
>> CC: Benjamin Herrenschmidt <benh@kernel•crashing.org>
>> CC: Paul Mackerras <paulus@samba•org>
>> CC: Michael Ellerman <mpe@ellerman•id.au>
>> CC: Peter Zijlstra <peterz@infradead•org>
>> CC: "Paul E. McKenney" <paulmck@linux•vnet.ibm.com>
>> CC: linuxppc-dev@lists•ozlabs.org
>> ---
>> arch/powerpc/kernel/entry_32.S | 7 +++++++
>> arch/powerpc/kernel/entry_64.S | 8 ++++++++
>> 2 files changed, 15 insertions(+)
>
> I don't _love_ the #ifdefs in here, but they look correct and there's
> not really a better option until we rewrite the syscall handler in C.
>
> The rseq selftests passed for me with this applied and enabled. So if
> you like here's some tags:
>
> Tested-by: Michael Ellerman <mpe@ellerman•id.au>
> Acked-by: Michael Ellerman <mpe@ellerman•id.au>
>
Adding you ack to the series.
Thanks!
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2018-06-05 12:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180602124408.8430-1-mathieu.desnoyers@efficios.com>
2018-06-02 12:44 ` [RFC PATCH for 4.18 08/16] powerpc: Add support for restartable sequences Mathieu Desnoyers
2018-06-02 12:44 ` [RFC PATCH for 4.18 09/16] powerpc: Add syscall detection " Mathieu Desnoyers
2018-06-05 5:21 ` Michael Ellerman
2018-06-05 12:50 ` Mathieu Desnoyers [this message]
2018-06-02 12:44 ` [RFC PATCH for 4.18 10/16] powerpc: Wire up restartable sequences system call Mathieu Desnoyers
2018-06-05 5:18 ` Michael Ellerman
2018-06-05 12:51 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448764618.5559.1528203010706.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios$(echo .)com \
--cc=ahh@google$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=andi@firstfloor$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bmaurer@fb$(echo .)com \
--cc=boqun.feng@gmail$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=cl@linux$(echo .)com \
--cc=davejwatson@fb$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=joelaf@google$(echo .)com \
--cc=josh@joshtriplett$(echo .)org \
--cc=linux-api@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@arm$(echo .)linux.org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=luto@amacapital$(echo .)net \
--cc=mingo@redhat$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=mtk.manpages@gmail$(echo .)com \
--cc=paulmck@linux$(echo .)vnet.ibm.com \
--cc=paulus@samba$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=pjt@google$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=torvalds@linux-foundation$(echo .)org \
--cc=will.deacon@arm$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox