From: Michael Ellerman <mpe@ellerman•id.au>
To: Anton Blanchard <anton@samba•org>,
benh@kernel•crashing.org, paulus@samba•org, mikey@neuling•org,
cyrilbur@gmail•com, scottwood@freescale•com
Cc: linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 09/19] powerpc: Move part of giveup_fpu,altivec,spe into c
Date: Tue, 01 Dec 2015 22:17:57 +1100 [thread overview]
Message-ID: <1448968677.18781.1.camel@ellerman.id.au> (raw)
In-Reply-To: <1446079451-8774-10-git-send-email-anton@samba.org>
On Thu, 2015-10-29 at 11:44 +1100, Anton Blanchard wrote:
> Move the MSR modification into new c functions. Removing it from
> the low level functions will allow us to avoid costly MSR writes
> by batching them up.
>
> Move the check_if_tm_restore_required() check into these new functions.
> diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
> index 5bf8ec2..6bcf82b 100644
> --- a/arch/powerpc/kernel/process.c
> +++ b/arch/powerpc/kernel/process.c
> @@ -214,6 +244,20 @@ EXPORT_SYMBOL_GPL(flush_vsx_to_thread);
> #endif /* CONFIG_VSX */
>
> #ifdef CONFIG_SPE
> +void giveup_spe(struct task_struct *tsk)
> +{
> + u64 oldmsr = mfmsr();
> + u64 newmsr;
> +
> + check_if_tm_restore_required(tsk);
We can't be building with SPE and also TM can we? I guess this is harmless as
it will compile to nothing, but it might be confusing to readers.
> + newmsr = oldmsr | MSR_SPE;
> + if (oldmsr != newmsr)
> + mtmsr_isync(newmsr);
> +
> + __giveup_spe(tsk);
> +}
> +EXPORT_SYMBOL(giveup_spe);
>
> void enable_kernel_spe(void)
> {
cheers
next prev parent reply other threads:[~2015-12-01 11:18 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 0:43 [PATCH 00/19] Context switch improvements Anton Blanchard
2015-10-29 0:43 ` [PATCH 01/19] powerpc: Don't disable kernel FP/VMX/VSX MSR bits on context switch Anton Blanchard
2015-12-07 10:30 ` [01/19] " Michael Ellerman
2015-10-29 0:43 ` [PATCH 02/19] powerpc: Don't disable MSR bits in do_load_up_transact_*() functions Anton Blanchard
2015-10-29 0:43 ` [PATCH 03/19] powerpc: Create context switch helpers save_sprs() and restore_sprs() Anton Blanchard
2017-09-02 3:42 ` Benjamin Herrenschmidt
2015-10-29 0:43 ` [PATCH 04/19] powerpc: Remove redundant mflr in _switch Anton Blanchard
2015-10-29 0:43 ` [PATCH 05/19] powerpc: Remove UP only lazy floating point and vector optimisations Anton Blanchard
2015-10-29 0:43 ` [PATCH 06/19] powerpc: Simplify TM restore checks Anton Blanchard
2015-10-29 0:43 ` [PATCH 07/19] powerpc: Create mtmsrd_isync() Anton Blanchard
2015-12-01 11:23 ` Michael Ellerman
2015-12-01 23:25 ` Michael Ellerman
2017-09-02 3:44 ` Benjamin Herrenschmidt
2015-10-29 0:44 ` [PATCH 08/19] powerpc: Remove NULL task struct pointer checks in FP and vector code Anton Blanchard
2015-10-29 0:44 ` [PATCH 09/19] powerpc: Move part of giveup_fpu,altivec,spe into c Anton Blanchard
2015-12-01 11:17 ` Michael Ellerman [this message]
2015-10-29 0:44 ` [PATCH 10/19] powerpc: Move part of giveup_vsx " Anton Blanchard
2015-10-29 0:44 ` [PATCH 11/19] crypto: vmx: Only call enable_kernel_vsx() Anton Blanchard
2015-10-29 0:44 ` [PATCH 12/19] powerpc: Create msr_check_and_{set,clear}() Anton Blanchard
2015-10-29 7:25 ` kbuild test robot
2015-10-29 0:44 ` [PATCH 13/19] powerpc: Create disable_kernel_{fp,altivec,vsx,spe}() Anton Blanchard
2015-10-29 0:44 ` [PATCH 14/19] powerpc: Add ppc_strict_facility_enable boot option Anton Blanchard
2017-09-02 3:48 ` Benjamin Herrenschmidt
2015-10-29 0:44 ` [PATCH 15/19] powerpc: Remove fp_enable() and vec_enable(), use msr_check_and_{set, clear}() Anton Blanchard
2015-10-29 0:44 ` [PATCH 16/19] powerpc: create giveup_all() Anton Blanchard
2015-12-02 8:24 ` Michael Ellerman
2015-10-29 0:44 ` [PATCH 17/19] powerpc: create flush_all_to_thread() Anton Blanchard
2015-10-29 0:44 ` [PATCH 18/19] powerpc: Rearrange __switch_to() Anton Blanchard
2015-10-29 0:44 ` [PATCH 19/19] powerpc: clean up asm/switch_to.h Anton Blanchard
2015-12-02 8:42 ` [PATCH 00/19] Context switch improvements Anshuman Khandual
2015-12-02 22:37 ` Michael Neuling
-- strict thread matches above, loose matches on Subject: below --
2015-10-28 0:50 [PATCH 01/19] powerpc: Don't disable kernel FP/VMX/VSX MSR bits on context switch Anton Blanchard
2015-10-28 0:50 ` [PATCH 09/19] powerpc: Move part of giveup_fpu,altivec,spe into c Anton Blanchard
2015-10-28 3:17 ` [PATCH 09/19] powerpc: Move part of giveup_fpu, altivec, spe " kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448968677.18781.1.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=anton@samba$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=cyrilbur@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mikey@neuling$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox