From: Michael Ellerman <mpe@ellerman•id.au>
To: "wen.pu@powercore•com.cn" <wen.pu@powercore•com.cn>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH] powerpc/opal: add warning for unimplemented OPAL message type
Date: Wed, 09 Dec 2015 11:17:12 +1100 [thread overview]
Message-ID: <1449620232.6028.5.camel@ellerman.id.au> (raw)
In-Reply-To: <20151208153012239673106@powercore.com.cn>
Hi Wen,
Thanks for the patch.
On Tue, 2015-12-08 at 15:30 +0800, wen.pu@powercore•com.cn wrote:
> I found that there are unimplemented OPAL message types "OPAL_MSG_EPOW" and
> "OPAL_MSG_DPO" in PowerNV Platform. If skiboot send such messages to kernel,
> nothing will happen(notifier_call_chain() will silently drop it). So I add a warning
> to inform what has happened, is it necessary?
What kernel version are you using?
Looking at mainline (4.4-rc4), I do see handlers registered for EPOW and DPO:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/powerpc/platforms/powernv/opal-power.c?#n82
That code was merged in 4.3.
In general I don't think we want to warn for unhandled message types, because
we support old kernels running on new skiboot. In that case if we warned on
every unhandled message we'd potentially spam the console with warnings.
But perhaps we can come up with something smarter, that only warns once for
each unhandled message type, or something like that? Did you have a bug that
would have been easier to debug with a warning here?
cheers
next prev parent reply other threads:[~2015-12-09 0:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 7:30 [PATCH] powerpc/opal: add warning for unimplemented OPAL message type wen.pu
2015-12-09 0:17 ` Michael Ellerman [this message]
2015-12-09 8:56 ` Wen Pu
-- strict thread matches above, loose matches on Subject: below --
2015-12-09 8:55 蒲文
2015-12-11 0:51 ` Stewart Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449620232.6028.5.camel@ellerman.id.au \
--to=mpe@ellerman$(echo .)id.au \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=wen.pu@powercore$(echo .)com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox