From: Joe Perches <joe@perches•com>
To: Russell King - ARM Linux <linux@arm•linux.org.uk>
Cc: "Michael S. Tsirkin" <mst@redhat•com>,
linux-kernel@vger•kernel.org,
"Cc : Andy Whitcroft" <apw@canonical•com>,
Peter Zijlstra <peterz@infradead•org>,
Arnd Bergmann <arnd@arndb•de>,
linux-arch@vger•kernel.org,
Andrew Cooper <andrew.cooper3@citrix•com>,
virtualization@lists•linux-foundation.org,
Stefano Stabellini <stefano.stabellini@eu•citrix.com>,
Thomas Gleixner <tglx@linutronix•de>, Ingo Molnar <mingo@elte•hu>,
"H. Peter Anvin" <hpa@zytor•com>,
David Miller <davem@davemloft•net>,
linux-ia64@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
linux-s390@vger•kernel.org, sparclinux@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-metag@vger•kernel.org, linux-mips@linux-mips•org,
x86@kernel•org, user-mode-linux-devel@lists•sourceforge.net,
adi-buildroot-devel@lists•sourceforge.net,
linux-sh@vger•kernel.org, linux-xtensa@linux-xtensa•org,
xen-devel@lists•xenproject.org, Ingo Molnar <mingo@kernel•org>,
Tony Lindgren <tony@atomide•com>,
Andrey Konovalov <andreyknvl@google•com>
Subject: Re: [PATCH 1/3] checkpatch.pl: add missing memory barriers
Date: Mon, 04 Jan 2016 08:15:14 -0800 [thread overview]
Message-ID: <1451924114.4334.85.camel@perches.com> (raw)
In-Reply-To: <20160104161123.GJ19062@n2100.arm.linux.org.uk>
On Mon, 2016-01-04 at 16:11 +0000, Russell King - ARM Linux wrote:
> On Mon, Jan 04, 2016 at 08:07:40AM -0800, Joe Perches wrote:
> > On Mon, 2016-01-04 at 13:36 +0200, Michael S. Tsirkin wrote:
> > > + my $all_barriers = join('|', (@barriers, @smp_barriers));
> > > +
> > > + if ($line =~ /\b($all_barriers)\(/) {
> >
> > It would be better to use /\b$all_barriers\s*\(/
> > as there's no reason for the capture and there
> > could be a space between the function and the
> > open parenthesis.
>
> I think you mean
>
> /\b(?:$all_barriers)\s*\(/
>
> as 'all_barriers' will be:
>
> mb|wmb|rmb|smp_mb|smp_wmb|smp_rmb
>
> and putting that into your suggestion results in:
>
> /\bmb|wmb|rmb|smp_mb|smp_wmb|smp_rmb\s*\(/
>
> which is clearly wrong - the \b only applies to 'mb' and the \s*\( only
> applies to smp_rmb.
right, thanks.
next prev parent reply other threads:[~2016-01-04 16:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 11:36 [PATCH 0/3] checkpatch: handling of memory barriers Michael S. Tsirkin
2016-01-04 11:36 ` [PATCH 1/3] checkpatch.pl: add missing " Michael S. Tsirkin
2016-01-04 16:07 ` Joe Perches
2016-01-04 16:11 ` Russell King - ARM Linux
2016-01-04 16:15 ` Joe Perches [this message]
2016-01-04 20:45 ` Michael S. Tsirkin
2016-01-04 22:15 ` Joe Perches
2016-01-10 11:42 ` Michael S. Tsirkin
2016-01-04 11:37 ` [PATCH 2/3] checkpatch: check for __smp outside barrier.h Michael S. Tsirkin
2016-01-04 11:37 ` [PATCH 3/3] checkpatch: add virt barriers Michael S. Tsirkin
2016-01-04 16:47 ` Joe Perches
2016-01-04 21:07 ` Michael S. Tsirkin
2016-01-04 22:11 ` Joe Perches
2016-01-08 10:14 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451924114.4334.85.camel@perches.com \
--to=joe@perches$(echo .)com \
--cc=adi-buildroot-devel@lists$(echo .)sourceforge.net \
--cc=andrew.cooper3@citrix$(echo .)com \
--cc=andreyknvl@google$(echo .)com \
--cc=apw@canonical$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=hpa@zytor$(echo .)com \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-metag@vger$(echo .)kernel.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-xtensa@linux-xtensa$(echo .)org \
--cc=linux@arm$(echo .)linux.org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@elte$(echo .)hu \
--cc=mingo@kernel$(echo .)org \
--cc=mst@redhat$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=stefano.stabellini@eu$(echo .)citrix.com \
--cc=tglx@linutronix$(echo .)de \
--cc=tony@atomide$(echo .)com \
--cc=user-mode-linux-devel@lists$(echo .)sourceforge.net \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=x86@kernel$(echo .)org \
--cc=xen-devel@lists$(echo .)xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox